Support cleaning up extra backup sites #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettanany
force-pushed
the
ettanany-support-cleaning-of-extra-backup-sites
branch
3 times, most recently
from
b6eb90d
to
b9980a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
- Coverage 91.01% 90.76% -0.25%
==========================================
Files 31 31
Lines 4917 4980 +63
==========================================
+ Hits 4475 4520 +45
- Misses 442 460 +18
|
ettanany
force-pushed
the
ettanany-support-cleaning-of-extra-backup-sites
branch
from
b9980a9
to
190f819
Compare
ettanany
force-pushed
the
ettanany-support-cleaning-of-extra-backup-sites
branch
from
190f819
to
82f226b
Compare
This adds a new setting called `extra_backup_sites_prefixes`, which when set, makes cleaning process look into those extra sites as well, and this is particularly useful when we have old backups from a previous backup site after a PG major version upgrade.
ettanany
force-pushed
the
ettanany-support-cleaning-of-extra-backup-sites
branch
from
82f226b
to
6b5e597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new setting called
extra_backup_sites_prefixes, which when set, makes cleaning process look into those extra sites as well, and this is particularly useful when we have old backups from a previous backup site after a PG major version upgrade.