Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encodes hashes hexadecimally instead of Base64 #18

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

ivanyu
Copy link
Collaborator

@ivanyu ivanyu commented Jun 10, 2020

Fixes #16

Also:

  • In HashTest.java, use explicit expected hashed values.
  • In HashTest.java, adds a test to check same input produces same output continuously.

@ivanyu ivanyu force-pushed the hash-encoding branch 2 times, most recently from 801a61d to 9f0222a Compare June 10, 2020 10:41
#16

Also:
- In `HashTest.java`, use explicit expected hashed values.
- In `HashTest.java`, adds a test to check same input produces same output continuously.
Copy link
Contributor

@willyborankin willyborankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willyborankin willyborankin merged commit c5a1eb4 into master Jun 10, 2020
@willyborankin willyborankin deleted the hash-encoding branch June 10, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode hashed values in hex instead of Base64
2 participants