Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation for new SMT ExtractTopicFromValueSchema and tests #93

Merged
merged 5 commits into from
Jun 11, 2023
Merged

Implementation for new SMT ExtractTopicFromValueSchema and tests #93

merged 5 commits into from
Jun 11, 2023

Conversation

mikaka-paf
Copy link
Contributor

Implementation for new SMT ExtractTopicFromValueSchema and tests

@mikaka-paf mikaka-paf requested review from a team as code owners May 22, 2023 09:54
@mikaka-paf mikaka-paf mentioned this pull request May 31, 2023
Closed
jjaakola-aiven
jjaakola-aiven requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @mikaka-paf.
I did a static pass of the code now, some notes and change requests commented.

src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
src/test/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaTest.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
...gration-test/java/io/aiven/kafka/connect/transforms/TopicFromValueSchemaIntegrationTest.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
@mikaka-paf mikaka-paf requested a review from jjaakola-aiven June 7, 2023 12:51
jjaakola-aiven
jjaakola-aiven requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more notes to improve the README.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/integration-test/java/io/aiven/kafka/connect/transforms/IntegrationTest.java Outdated Show resolved Hide resolved
@mikaka-paf mikaka-paf requested a review from jjaakola-aiven June 8, 2023 07:47
jjaakola-aiven
jjaakola-aiven previously approved these changes Jun 8, 2023
View reviewed changes
@mikaka-paf mikaka-paf force-pushed the Initial-test-with-SMT-ExtractTopicFromEventType branch from 673f9c3 to 06d5c1d Compare June 8, 2023 08:05
@jjaakola-aiven
Copy link
Contributor

@mikaka-paf Could you still fix the typo from commit message to Implementation for new SMT extractTopicFromValueSchema and tests. Missing e in the xtractTopic....

@mikaka-paf mikaka-paf force-pushed the Initial-test-with-SMT-ExtractTopicFromEventType branch from 06d5c1d to 08c0396 Compare June 8, 2023 08:36
AnatolyPopov
AnatolyPopov requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
@mikaka-paf mikaka-paf requested a review from AnatolyPopov June 8, 2023 13:23
AnatolyPopov
AnatolyPopov requested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchema.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaConfig.java Outdated Show resolved Hide resolved
src/test/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaTest.java Outdated Show resolved Hide resolved
src/test/java/io/aiven/kafka/connect/transforms/ExtractTopicFromValueSchemaTest.java Outdated Show resolved Hide resolved
@mikaka-paf mikaka-paf requested a review from AnatolyPopov June 9, 2023 07:46
@mikaka-paf mikaka-paf requested a review from AnatolyPopov June 9, 2023 12:38
AnatolyPopov
AnatolyPopov requested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromSchemaName.java Show resolved Hide resolved
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopicFromSchemaName.java Outdated Show resolved Hide resolved
@mikaka-paf mikaka-paf requested a review from AnatolyPopov June 11, 2023 07:32
AnatolyPopov
AnatolyPopov approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fro addressing all the comments @mikaka-paf! Looks good to me know.

@AnatolyPopov AnatolyPopov merged commit a227738 into Aiven-Open:master Jun 11, 2023
@jeqo jeqo mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnatolyPopov AnatolyPopov AnatolyPopov approved these changes

@jjaakola-aiven jjaakola-aiven jjaakola-aiven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaka-paf @jjaakola-aiven @AnatolyPopov