Keep themed trainers #702
Keep themed trainers #702
Conversation
also changed the specs for "bird override", that one was a bit of an afterthought
-superglobal (is more difficult than expected, and not truly what I wanted) +"Use local pokemon" (what I actually wanted) +preserve primary type (trainers) & +preserve type themed trainers
(cherry picked from commit 16fc3ff) # Conflicts: # src/com/dabomstew/pkrandom/romhandlers/AbstractRomHandler.java
very easy
now accurately describes the feature as implemented.
|
hello, this seems like an awesome addition to the randomizer. just a question though (im a noob lol) how would one actually run this fork? do you need to create the jar file from the src folder or something? this seems sick but obviously the jar file isnt contained in the source files and since the launcher needs to be in the same folder as the jar, it doesnt actually work. |
Yeah, I haven't made a release yet; there's a few missing/broken features that need to be completed first. Right now, the only way to run this would be to follow the guide to building the project from source provided by the ZX team (replacing the URL to the repository with my repo's). I'll try to prioritize release, now that I know I have at least one person waiting! |
|
whoops I hyperfocused. There's a release now! |
This pull request fulfills Issue #701 "Keep Original Type Themes" for trainers.
Readme.MD has been changed to describe the fork and should not be included in the merge commit.
This branch adds a new feature, "Keep Type Themed Trainers' Themes", to the Trainer Pokemon main dropdown.
This feature determines if a trainer has an existing type theme, and if so, assigns only Pokemon of that type to the trainer. All other trainers will have random Pokemon.
The code adds a necessary pair of properties to the Pokemon class (originalPrimaryType, originalSecondaryType) and initializes their values in AbstractRomHandler.setPokemonPool. Other than this, it makes no changes beyond those necessary to create a setting, add it to the GUI, and implement it in randomizeTrainerPokes.