Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect video seek for certain m2ts #19

Closed
AkarinVS opened this issue Nov 23, 2021 · 1 comment
Closed

incorrect video seek for certain m2ts #19

AkarinVS opened this issue Nov 23, 2021 · 1 comment
Assignees
Labels
video video related

Comments

@AkarinVS
Copy link
Owner

AkarinVS commented Nov 23, 2021

sample: KIXA90240/BDMV/STREAM/00000.m2ts (md5sum a508b825171a843a15dcb5a7c882f6ef)
There are more cases, mostly in older BDs.

lsmas consistently fails to decode frame 351 (P frame) and more....
However, it can decode that frame correctly after remuxing the m2ts as mkv.
(ffms2 also exhibits similar problems with the m2ts file.)

Note: this is a severe issue for affected video files because not only does it affect random seeking, it might also affect vspipe-based encoding (as VS R54 can't guarantee strict sequential frame accesses under all circumstances.)

@AkarinVS AkarinVS added the video video related label Nov 23, 2021
@AkarinVS AkarinVS self-assigned this Nov 29, 2021
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Nov 29, 2021
… found

This should help AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Nov 29, 2021
… found

This should help AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
@AkarinVS
Copy link
Owner Author

AkarinVS commented Dec 6, 2021

Not yet fixed.
sample: KIXA90240/BDMV/STREAM/00003.m2ts, frame 2150.

again, current lsmas vA.3h release and ffms2 both failed to correctly decode this frame (when randomly accessed).
This time, remuxing the video into mkv does not help.

Frame 2148 (IDR) and 2149 (I) are both I frames with 2149 labeled with recovery point SEI as a valid random access point (with exact_match_flag=1).
Frame 2150 is a P frame referencing both 2148 and 2149, making 2149 not a valid random access point.
Compounding this issue is that, 2148 is not a valid random access point either because it lacks its own SPS and PPS.

Even though one can argue that this input might be an incorrectly encoded file, this issue is serious enough that we have no choice but to somehow build a workaround.

@AkarinVS AkarinVS reopened this Dec 6, 2021
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Dec 6, 2021
… found & slice is IDR

This should finally fix AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Dec 6, 2021
… found & slice is IDR

This should finally fix AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Jan 12, 2022
… found

This should help AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Jan 12, 2022
… found & slice is IDR

This should finally fix AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Jan 19, 2022
… found

This should help AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
AkarinVS added a commit to AkarinVS/FFmpeg that referenced this issue Jan 19, 2022
… found & slice is IDR

This should finally fix AkarinVS/L-SMASH-Works#19.

Signed-off-by: akarin <i@akarin.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
video video related
Projects
None yet
Development

No branches or pull requests

1 participant