forked from aquasecurity/cloudsploit
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1 from AkhtarAmir/feature/ec2-plugin-mark-launch-…
…wizard-security-groups Feature/ec2 plugin mark launch wizard security groups
- Loading branch information
Showing
6 changed files
with
217 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| var async = require('async'); | ||
| var helpers = require('../../../helpers/aws'); | ||
|
|
||
| module.exports = { | ||
| title: 'EC2 LaunchWizard Security Groups', | ||
| category: 'EC2', | ||
| description: 'Ensures security groups created by the EC2 launch wizard are not used', | ||
| more_info: 'The EC2 launch wizard frequently creates insecure security groups that are exposed publicly. These groups should not be used and custom security groups should be created instead.', | ||
| link: 'https://docs.aws.amazon.com/launchwizard/latest/userguide/launch-wizard-sap-security-groups.html', | ||
| recommended_action: 'Delete the launch wizard security group and replace it with a custom security group.', | ||
| apis: ['EC2:describeSecurityGroups'], | ||
|
|
||
| run: function(cache, settings, callback) { | ||
| var results = []; | ||
| var source = {}; | ||
| var regions = helpers.regions(settings); | ||
|
|
||
| async.each(regions.ec2, function(region, rcb){ | ||
| var describeSecurityGroups = helpers.addSource(cache, source, | ||
| ['ec2', 'describeSecurityGroups', region]); | ||
|
|
||
| if (!describeSecurityGroups) return rcb(); | ||
|
|
||
| if (describeSecurityGroups.err || !describeSecurityGroups.data) { | ||
| helpers.addResult(results, 3, | ||
| 'Unable to query for security groups: ' + helpers.addError(describeSecurityGroups), region); | ||
| return rcb(); | ||
| } | ||
|
|
||
| if (!describeSecurityGroups.data.length) { | ||
| helpers.addResult(results, 0, 'No security groups present', region); | ||
| return rcb(); | ||
| } | ||
|
|
||
| for (var s in describeSecurityGroups.data) { | ||
| var sg = describeSecurityGroups.data[s]; | ||
| var resource = sg.GroupId; | ||
|
|
||
| if (sg.GroupName.toLowerCase().startsWith('launch-wizard')) { | ||
| helpers.addResult(results, 2, | ||
| 'Security Group ' + sg.GroupName + ' was launched using EC2 launch wizard', | ||
| region, resource); | ||
| } else { | ||
| helpers.addResult(results, 0, | ||
| 'Security Group ' + sg.GroupName + ' was not launched using EC2 launch wizard', | ||
| region, resource); | ||
| } | ||
| } | ||
|
|
||
| rcb(); | ||
| }, function(){ | ||
| callback(null, results, source); | ||
| }); | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| var expect = require('chai').expect; | ||
| const launchWizardSecurityGroups = require('./launchWizardSecurityGroups'); | ||
|
|
||
| const securityGroups = [ | ||
| { | ||
| "Description": "launch-wizard-1 created 2020-08-10T14:28:09.271+05:00", | ||
| "GroupName": "launch-wizard-1", | ||
| "IpPermissions": [ | ||
| { | ||
| "FromPort": 22, | ||
| "IpProtocol": "tcp", | ||
| "IpRanges": [ | ||
| { | ||
| "CidrIp": "0.0.0.0/0" | ||
| } | ||
| ], | ||
| "Ipv6Ranges": [], | ||
| "PrefixListIds": [], | ||
| "ToPort": 22, | ||
| "UserIdGroupPairs": [] | ||
| } | ||
| ], | ||
| "OwnerId": "560213429563", | ||
| "GroupId": "sg-0ff1642cae23c309a", | ||
| "IpPermissionsEgress": [ | ||
| { | ||
| "IpProtocol": "-1", | ||
| "IpRanges": [ | ||
| { | ||
| "CidrIp": "0.0.0.0/0" | ||
| } | ||
| ], | ||
| "Ipv6Ranges": [], | ||
| "PrefixListIds": [], | ||
| "UserIdGroupPairs": [] | ||
| } | ||
| ], | ||
| "Tags": [], | ||
| "VpcId": "vpc-99de2fe4" | ||
| }, | ||
| { | ||
| "Description": "Allows SSh access to developer", | ||
| "GroupName": "spec-test-sg", | ||
| "IpPermissions": [], | ||
| "OwnerId": "560213429563", | ||
| "GroupId": "sg-0b5f2771716acfee4", | ||
| "IpPermissionsEgress": [ | ||
| { | ||
| "FromPort": 22, | ||
| "IpProtocol": "tcp", | ||
| "IpRanges": [ | ||
| { | ||
| "CidrIp": "0.0.0.0/0" | ||
| } | ||
| ], | ||
| "Ipv6Ranges": [ | ||
| { | ||
| "CidrIpv6": "::/0" | ||
| } | ||
| ], | ||
| "PrefixListIds": [], | ||
| "ToPort": 22, | ||
| "UserIdGroupPairs": [] | ||
| } | ||
| ], | ||
| "Tags": [], | ||
| "VpcId": "vpc-99de2fe4" | ||
| } | ||
| ]; | ||
|
|
||
| const createCache = (securityGroups) => { | ||
| return { | ||
| ec2: { | ||
| describeSecurityGroups: { | ||
| 'us-east-1': { | ||
| data: securityGroups | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
| }; | ||
|
|
||
| const createErrorCache = () => { | ||
| return { | ||
| ec2: { | ||
| describeSecurityGroups: { | ||
| 'us-east-1': { | ||
| err: { | ||
| message: 'error describing security groups' | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
| }; | ||
|
|
||
| const createNullCache = () => { | ||
| return { | ||
| ec2: { | ||
| describeSecurityGroups: { | ||
| 'us-east-1': null, | ||
| }, | ||
| }, | ||
| }; | ||
| }; | ||
|
|
||
| describe('launchWizardSecurityGroups', function () { | ||
| describe('run', function () { | ||
| it('should PASS if security groups was not created using EC2 launch wizard', function (done) { | ||
| const cache = createCache([securityGroups[1]]); | ||
| launchWizardSecurityGroups.run(cache, {}, (err, results) => { | ||
| expect(results.length).to.equal(1); | ||
| expect(results[0].status).to.equal(0); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should FAIL if security groups was created using EC2 launch wizard', function (done) { | ||
| const cache = createCache([securityGroups[0]]); | ||
| launchWizardSecurityGroups.run(cache, {}, (err, results) => { | ||
| expect(results.length).to.equal(1); | ||
| expect(results[0].status).to.equal(2); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should PASS if no security groups are detected', function (done) { | ||
| const cache = createCache([]); | ||
| launchWizardSecurityGroups.run(cache, {}, (err, results) => { | ||
| expect(results.length).to.equal(1); | ||
| expect(results[0].status).to.equal(0); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should UNKNOWN if there was an error describing security groups', function (done) { | ||
| const cache = createErrorCache(); | ||
| launchWizardSecurityGroups.run(cache, {}, (err, results) => { | ||
| expect(results.length).to.equal(1); | ||
| expect(results[0].status).to.equal(3); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it('should not return any results if unable to query for security groups', function (done) { | ||
| const cache = createNullCache(); | ||
| launchWizardSecurityGroups.run(cache, {}, (err, results) => { | ||
| expect(results.length).to.equal(0); | ||
| done(); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters