style(theme): add standard CSS mask declaration for theme.css #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkbox fix
add presets
update presets
minor fix
update preset
update preset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Obsidian is based on Chromium, Chromium itself can now recognize standard mask declarations (e.g.,
mask,mask-image,mask-size, etc.). Therefore, using standard declarations can ensure understanding.This PR consisted of two commits: the first commit does nothing but reformatted
theme.csswith default prettier settings, and the second added standardized CSS declarations for CSS masks behind webkit-specific ones to ensure backward compatibility for older versions of Obsidian.You can check the second commit log for literal changes.