Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exceptions for failed commands in BinaryRenderer #37

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

notFloran
Copy link
Member

We let symfony process handle the exceptions by using mustRun method.

Example:

The command "'mjml-not-found' '-V'" failed.

Exit Code: 127(Command not found)

Working directory: /Users/floranbrutel/dev/mjml-bundle

Output:
================


Error Output:
================
sh: line 0: exec: mjml-not-found: not found
" at
/Users/floranbrutel/dev/mjml-bundle/vendor/symfony/process/Process.php:256
/Users/floranbrutel/dev/mjml-bundle/src/Renderer/BinaryRenderer.php:40
We let symfony process handle the exceptions by using mustRun method
/Users/floranbrutel/dev/mjml-bundle/src/Renderer/BinaryRenderer.php:59
/Users/floranbrutel/dev/mjml-bundle/tests/Renderer/BinaryRendererTest.php:32
.

@notFloran notFloran changed the title Better exceptions for failed commands in BinaryRenderer WIP: Better exceptions for failed commands in BinaryRenderer May 30, 2019
@notFloran notFloran changed the title WIP: Better exceptions for failed commands in BinaryRenderer Better exceptions for failed commands in BinaryRenderer Jun 12, 2019
@notFloran notFloran merged commit 3e3192f into master Jun 12, 2019
@notFloran notFloran deleted the binary-renderer-exceptions branch June 12, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant