Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ater updating to v5.1 the v-close-popper directive no longer works #1013

Closed
kouts opened this issue Jan 16, 2024 · 1 comment
Closed

Ater updating to v5.1 the v-close-popper directive no longer works #1013

kouts opened this issue Jan 16, 2024 · 1 comment

Comments

@kouts
Copy link
Contributor

kouts commented Jan 16, 2024

It seems that the change from click to mousedown introduced in v5.1 broke the v-close-popper directive, so clicking on an element that has the directive no longer closes the popper.

Here's a Stackblitz showcasing the issue, you'll notice that the dropdown that uses hide works as expected while the one using v-close-popper does not.

https://stackblitz.com/edit/vue3-tailwind-ad4rfl?file=src%2FApp.vue

I think the issue probably lies here:

el.addEventListener('click', onClick)

I tried to fork the project and follow the contributing guidelines but I wasn't able to fire-up the dev environment.

@kouts
Copy link
Contributor Author

kouts commented Jan 17, 2024

Thanks, @antfu for reviewing and @Akryum for merging this.
I appreciate you guys for your efforts in keeping this library current.

@kouts kouts closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant