Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix v-close-popper to function on mousedown #1014

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

kouts
Copy link
Contributor

@kouts kouts commented Jan 16, 2024

This PR fixes an issue #1013 where the v-close-popper directive wouldn't work after v5.1.

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for v-tooltip ready!

Name Link
🔨 Latest commit 01cf75f
🔍 Latest deploy log https://app.netlify.com/sites/v-tooltip/deploys/65a6660a5e237d0009761fad
😎 Deploy Preview https://deploy-preview-1014--v-tooltip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kouts
Copy link
Contributor Author

kouts commented Jan 16, 2024

@Akryum, @antfu I managed to test this PR by directly editing the code inside node_modules/floating-vue/dist/floating-vue.mjs in my project since I wasn't able to build the dev environment (maybe the CONTRIBUTING.md file needs updating?).

This is the error that I get running pnpm run docs

image

@Akryum Akryum merged commit f67c077 into Akryum:main Jan 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants