Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache service-worker.js when using pwa plugin #22

Closed
Narkoleptika opened this issue Sep 16, 2018 · 2 comments · Fixed by #53
Closed

Don't cache service-worker.js when using pwa plugin #22

Narkoleptika opened this issue Sep 16, 2018 · 2 comments · Fixed by #53

Comments

@Narkoleptika
Copy link

Hello, thanks for this and the apollo plugins! Just a real quick change here.

I'm using this plugin along with the pwa plugin and am receiving the following warning on Chrome 69.0.3497.92

screenshot from 2018-09-15 22-26-33

The last argument to serve needs to either be omitted or changed to false on the following line: https://github.com/Akryum/vue-cli-plugin-ssr/blob/master/lib/app.js#L80

Thanks!

@mrksbnch
Copy link

mrksbnch commented Jan 5, 2019

@Akryum As this should probably be fixed and is an easy change (https://github.com/Akryum/vue-cli-plugin-ssr/blob/master/lib/app.js#L83), would you accept a MR for this?

@Akryum
Copy link
Owner

Akryum commented Jan 5, 2019

Of course! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants