Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependabot-automerge.yml to work with recent GitHub changes (08-03-2021 #55

Closed
wants to merge 1 commit into from

Conversation

DutchmanNL
Copy link

Based on recent changes, the current workflow does no allow to be used on public repository anymore (recent change on 8-march by GiHub).

This modification works and is in line with issues mention at the published workflow.
(see related issue and fix ahmadnassri/action-dependabot-auto-merge#60 (comment))

Working and tested implementation can be reviewed at my organization https://github.com/drozmotiX/
(all adapters used this flow now)

Based on recent changes, the current workflow does no allow to be used on public repository anymore (recent change on 8-march by GiHub).

This modification works and is in line with issues mention at the published workflow.
(see related issue and fix ahmadnassri/action-dependabot-auto-merge#60 (comment))

Working and tested implementation can be reviewed at my organization https://github.com/drozmotiX/
(all adapters used this flow now)
@UncleSamSwiss
Copy link
Contributor

Was it your intention to only fix the adapter creator itself and not the generated adapters?

@DutchmanNL
Copy link
Author

Was it your intention to only fix the adapter creator itself and not the generated adapters?

we should in basic solve this directly in the creator to avoid issue with new adapters.
Updating all existing one is a good suggestion, however I no sure how o automate this and not all adapters use it.
I raised a topic for our Dev-Meting. to inform all developers. implementing the change (if they want to)

@AlCalzone
Copy link
Owner

He meant you did not update the template (and the baselines), but only for the creator repo itself.

Also I don't think these changes make sense (see telegram)

@UncleSamSwiss
Copy link
Contributor

... actually we are in the wrong repo! This is the release script :D

@AlCalzone AlCalzone closed this Mar 23, 2021
@DutchmanNL DutchmanNL deleted the patch-1 branch March 23, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot latest change renders this action unusable for public repos
3 participants