Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lit 3.0 is causing issues that need to be reviewed #215

Closed
blackfalcon opened this issue Sep 24, 2021 · 1 comment · Fixed by #216
Closed

Lit 3.0 is causing issues that need to be reviewed #215

blackfalcon opened this issue Sep 24, 2021 · 1 comment · Fixed by #216
Assignees
@blackfalcon
Labels
Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

Describe the bug

A recent upgrade to auro-banner produced an error where v3.0 fo Lit Element caused the element to break.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any element
  2. Upgrade to lit-element v3.0
  3. npm run build
  4. See error

Expected behavior

The element does not break with build
@blackfalcon blackfalcon added the Type: Bug Bug or Bug fixes label Sep 24, 2021
@blackfalcon blackfalcon self-assigned this Sep 24, 2021
blackfalcon added a commit that referenced this issue Sep 24, 2021
@blackfalcon
fix(lit): fix generator to use v2.5.1 of LitElement #215
aaabcfe
@blackfalcon blackfalcon mentioned this issue Sep 24, 2021
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Sep 24, 2021 that will close this issue
fix(lit): fix generator to use v2.5.1 of LitElement #215 #216
Merged
6 tasks
@braven112 braven112 added this to the v4.0-rc milestone Sep 24, 2021
@braven112 braven112 mentioned this issue Sep 24, 2021
Closed
7 tasks
@blackfalcon
Copy link
Member Author

Follow up issue

blackfalcon added a commit that referenced this issue Sep 24, 2021
@blackfalcon
fix(lit): fix generator to use v2.5.1 of LitElement #215
b5d2f37
blackfalcon pushed a commit that referenced this issue Sep 24, 2021
@semantic-release-bot
chore(release): 3.9.1 [skip ci]
ddaa7a1 
## [3.9.1](v3.9.0...v3.9.1) (2021-09-24)

### Bug Fixes

* **lit:** fix generator to use v2.5.1 of LitElement [#215](#215) ([b5d2f37](b5d2f37))
@blackfalcon blackfalcon removed this from the wc-generator v4.0-rc milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lit): fix generator to use v2.5.1 of LitElement #215 AlaskaAirlines/WC-Generator
2 participants
@blackfalcon @braven112