Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplication of resources #385

Closed
blackfalcon opened this issue May 3, 2023 · 1 comment · Fixed by #383
Closed

Duplication of resources #385

blackfalcon opened this issue May 3, 2023 · 1 comment · Fixed by #383
Assignees
@blackfalcon
Labels
Type: Bug Bug or Bug fixes
Milestone
Generator RC v4.0

Comments

@blackfalcon
Copy link
Member

Describe the bug

The packaged released version of the element, the element's JS is in both the ./src and the ./dist dir. This is not necessary.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://www.runpkg.com/?@aurodesignsystem/auro-hyperlink@3.3.3/index.js
  2. Open both the ./src and the ./dist directory
  3. See error

Expected behavior

Only one version is necessary in the package.

Exit criteria

This issue is complete once there is only one version of the resource in the ./src directory.
@blackfalcon blackfalcon added this to the Generator RC v4.0 milestone May 3, 2023
@blackfalcon blackfalcon self-assigned this May 3, 2023
@blackfalcon
Copy link
Member Author

This update will also need to be applied to the following updated to al recently updated repos where the new extension model has been applied.

  1. auro-header
  2. auro-icon
  3. auro-input
  4. auro-dropdown
  5. auro-button (in progress of update at this time)
  6. auro-badge
  7. auro-avatar?

There is also an issue with bundles not being minimized... see the following open issue with auro-avatar

@blackfalcon blackfalcon linked a pull request May 3, 2023 that will close this issue
Irmaku/wc generator issue #383
Merged
3 tasks
blackfalcon added a commit that referenced this issue May 4, 2023
@blackfalcon
perf(npmignore): update config #385
4741594 
Changes to be committed:
modified:   template/.npmignore.temp
@blackfalcon blackfalcon mentioned this issue May 4, 2023
Merged
3 tasks
blackfalcon added a commit that referenced this issue May 5, 2023
@blackfalcon
perf(npmignore): update config #385
20f9e46 
Changes to be committed:
modified:   template/.npmignore.temp
blackfalcon added a commit that referenced this issue May 5, 2023
@blackfalcon
perf(ignore): update configs #385
f678256 
Changes to be committed:
modified:   template/.npmignore.temp
modified:   template/.gitignore.temp
blackfalcon added a commit that referenced this issue May 5, 2023
@blackfalcon
perf(ignore): update configs #385
2ced29a 
Changes to be committed:
modified:   template/.npmignore.temp
modified:   template/.gitignore.temp
blackfalcon added a commit that referenced this issue May 9, 2023
@blackfalcon
perf(ignore): update configs #385
ea52043 
Changes to be committed:
modified:   template/.npmignore.temp
modified:   template/.gitignore.temp
blackfalcon pushed a commit that referenced this issue May 9, 2023
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
d1b5930 
# [4.0.0](v3.17.4...v4.0.0) (2023-05-09)

### Bug Fixes

* automatically generate TypeScript description files ([dea833e](dea833e))
* generator: update CDN reference [#382](#382) ([cb65617](cb65617))
* **reference:** update to use [@AuroDesignSystem](https://github.com/aurodesignsystem) [#345](#345) ([1a628fa](1a628fa))
* **sec:** remove inefficient regular expression [#357](#357) ([c726423](c726423))
* update docs on issue template ([acd5531](acd5531))

### Features

* address general issues to get build working ([a4eba9a](a4eba9a))
* **typescript:** add typescript support ([a2d48e0](a2d48e0))

### Performance Improvements

* **ignore:** update configs [#385](#385) ([ea52043](ea52043))
* **labs:** remove auroLabs functionality [#339](#339) ([f32d69f](f32d69f))
* remove deprecated stylelint rules [#381](#381) ([568016e](568016e))
* remove IE support [#181](#181) ([c8543b3](c8543b3))
* remove polyfill focus visible ([6b68814](6b68814))
* **review:** add all suggested updates ([268e86a](268e86a))
* **settings:** update labels [#377](#377) ([c2cccf7](c2cccf7))
* **watch:** add apiExamples to generate docs [#320](#320) ([32c005f](32c005f))
* **windows:** update dev script [#274](#274) ([5efb6f8](5efb6f8))

### Reverts

* .npmignore and update .npmignore.temp ([85a135f](85a135f))
* return removed regex [#357](#357) ([08e2957](08e2957))

### BREAKING CHANGES

* **labs:** This commit will remove all functionality related
to the use of AuroLabs as a concept.

Changes to be committed:
modified:   bin/generate.js
modified:   componentDocs/README.md
modified:   componentDocs/README_v4.md
deleted:    componentDocs/partials/labsDisclaimer.md
deleted:    template/.github/settings__labs.yml
modified:   template/scripts/generateDocs.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
Generator RC v4.0
Development

Successfully merging a pull request may close this issue.

Irmaku/wc generator issue AlaskaAirlines/WC-Generator
2 participants
@blackfalcon @braven112