Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis process #4

Closed
blackfalcon opened this issue Jul 25, 2019 · 1 comment
Closed

Travis process #4

blackfalcon opened this issue Jul 25, 2019 · 1 comment
Assignees
Labels
Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

Incorrect scripts

Make the following updates to the .travis.yml, package.json and gulpfile.js files

travis.yml

Remove

gulp reprocessClean
npm run copyResources
npm run copyDocs

package.json

Edit

    "stylefluxCanonical": "styleflux -o ./altImports/canonical/*.css",
    "stylefluxVariable": "styleflux -o ./altImports/variable/*.css",

gulpfile.js

Remove

gulp.task('reprocessClean', function() { ... }

Fix

gulp.task('processImportsCanonical', function() {}
gulp.task('processImportsVariable', function() {}

gitignore

Edit

## Sass files built on demand from Token files
demo/sass/_*.scss
tokens/
altImports/
@blackfalcon blackfalcon added the Type: Bug Bug or Bug fixes label Jul 25, 2019
@blackfalcon blackfalcon self-assigned this Jul 25, 2019
AuroDesignSystem pushed a commit that referenced this issue Jul 31, 2019
## [1.0.13](v1.0.12...v1.0.13) (2019-07-31)

### Bug Fixes

* [#4](#4) address all tempate file issues ([b2c339d](b2c339d))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 1.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

fajar-apri-alaska added a commit that referenced this issue Jan 30, 2024
- Update below regex to make it more efficient:
\r\n|\r|\n -> \r?\n|\r(?!\n)

1. The \r\n is redundant to \r checking in current pattern,
and I think we can combine it with the \n checking by using \r?\n
2. At first, I want to also remove the standalone \r because it only for older Mac OS,
but I think we should keep it for backward compatibility, so adding | \r to the pattern.
3. Additional (?!\n) in the end is to make sure the \r is not followed by \n,
to avoid exponential backtracking on strings starting with '''
and containing many repetitions of '\r\n'. (per latest CodeQL analysis alert #4)

Changes to be committed:
	modified:   package-lock.json
	modified:   template/scripts/generateDocs.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants