Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wc-generate: localhost port documentation is incorrect in package.json #58

Closed
jason-capsule42 opened this issue Jan 24, 2021 · 1 comment · Fixed by #59
Closed

wc-generate: localhost port documentation is incorrect in package.json #58

jason-capsule42 opened this issue Jan 24, 2021 · 1 comment · Fixed by #59
Assignees
Labels
released Completed work has been released Type: Bug Bug or Bug fixes

Comments

@jason-capsule42
Copy link
Member

Describe the bug

When using wc-generate to start a new project, the generated package.json includes information for starting your localhost and how to run it in your local browser. However, the package.json designates the wrong port.

To Reproduce

Steps to reproduce the behavior:

  1. Start a new project from scratch
  2. Run 'wc-generate --name counter'
  3. Open ./package.json and review the first section describing how to start your localhost
  4. Note that the url designated is "localhost:3001"

Expected behavior

This should say "localhost:8000"

Desktop (please complete the following information):

  • OS: macOS Big Sur
  • Version 11.1

Additional Information

Note that all other documentation sources give the correct localhost:8000 instructions.

@jason-capsule42 jason-capsule42 added the Type: Bug Bug or Bug fixes label Jan 24, 2021
@geoffrich geoffrich assigned geoffrich and unassigned blackfalcon Jan 25, 2021
AuroDesignSystem pushed a commit that referenced this issue Jan 26, 2021
## [2.9.5](v2.9.4...v2.9.5) (2021-01-26)

### Bug Fixes

* [#58](#58) specify correct port in package json ([f55589e](f55589e))
* update node version check ([856fff5](856fff5))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 2.9.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants