Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to general developer experience #265

Merged
merged 11 commits into from
Nov 15, 2021
Merged

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Nov 11, 2021

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Remove question from generator #263 This commit removes the init question asking the user if they have the most recent version of the Generator installed.
  • Manage node version from package.json #262 This commit adds support for dynamic management of node version support via setting the value in the Generator's package.json file. This removed the need to update this value in multiple locations.
  • Run multiple npm scripts in parallel #225 This commit increases dev experience by activating a dev server and Sass watcher with a single shell and single command. $ npm run dev now runs all the things.
  • Use npx versus npm #222 This commit will change the install and init script to use npx allowing users to never have to worry about maintaining a local install version. Running npx will pull the latest version of the generator on-demand and run the necessary command.
  • SCSS linter has been failing with update to stylelint 14 #267 WIth the update of stylelint 14, it appears that the linters have been failing, but not stopping the build. It's a slient error because the v14 API changes. This commit updates the generator to support the new v14 API.
  • build:demo fails looking for css file that does not exist #268 Running npm run build:demo has been failing at the part where it is trying to retrieve a CSS files that no longer exists. The commit removed that code.
  • Update to support node 16 #269 During the review, it was concluded that we should simply support Node 16 as the base version. This commit updates all the supporting areas where node versions are referenced.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@blackfalcon blackfalcon self-assigned this Nov 11, 2021
@blackfalcon blackfalcon linked an issue Nov 11, 2021 that may be closed by this pull request
@blackfalcon blackfalcon linked an issue Nov 11, 2021 that may be closed by this pull request
@blackfalcon blackfalcon changed the base branch from master to v3.11-rc November 11, 2021 06:41
@blackfalcon blackfalcon marked this pull request as ready for review November 11, 2021 06:41
@blackfalcon blackfalcon requested a review from a team as a code owner November 11, 2021 06:41
@blackfalcon blackfalcon linked an issue Nov 11, 2021 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
template/.eslintrc Outdated Show resolved Hide resolved
template/package.json Show resolved Hide resolved
@blackfalcon blackfalcon linked an issue Nov 12, 2021 that may be closed by this pull request
@blackfalcon blackfalcon merged commit e3c1522 into v3.11-rc Nov 15, 2021
@blackfalcon blackfalcon deleted the dsande/v3.11-rc/#264 branch November 15, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants