fix: update ineff regex #357 #410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
blackfalcon
force-pushed
the
izook/ineffRegEx/#357
branch
from
90b4ec4 to
a7e1841
Compare
|
Using this brach, I built a test repo and this is how the demo page looks.
|
blackfalcon
requested changes
Jul 6, 2023
template/scripts/generateDocs.js
Outdated
| @@ -59,7 +59,7 @@ function formatTemplateFileContents(content, destination) { | |||
| result = result.replace(/>(\r\n|\r|\n){2,}/g, '>\r\n'); // Remove empty lines directly after a closing html tag. | |||
| result = result.replace(/>(\r\n|\r|\n)```/g, '>\r\n\r\n```'); // Ensure an empty line before code samples. | |||
| result = result.replace(/>(\r\n|\r|\n){2,}```(\r\n|\r|\n)/g, '>\r\n```\r\n'); // Ensure no empty lines before close of code sample. | |||
| result = result.replace(/([^(\r\n|\r|\n)])(\r\n|\r|\n)+#/g, "$1\r\n\r\n#"); // Ensure empty line before header sections. | |||
| result = result.replace(/([^\r\n])([\r\n|\r|\n]+)/g, "$1\r\n\r\n#"); // Ensure empty line before header sections. | |||
There was a problem hiding this comment.
This regex will malform the output of HTML from the markdown docs.
Izook
force-pushed
the
izook/ineffRegEx/#357
branch
from
a7e1841 to
5108ace
Compare
blackfalcon
force-pushed
the
izook/ineffRegEx/#357
branch
from
5108ace to
a7f7ef0
Compare
blackfalcon
requested changes
Jul 10, 2023
| fs.readFile('./demo/apiExamples.md', 'utf8', function(err, data) { | ||
| formatTemplateFileContents(data, './demo/apiExamples.md'); | ||
| fs.readFile('./demo/api.md', 'utf8', function(err, data) { | ||
| formatTemplateFileContents(data, './demo/api.md'); |
There was a problem hiding this comment.
I get the following error traced back to this update
./index.js → dist/...
created dist/ in 266ms
/Users/dalesande/src/auro/test-element/scripts/generateDocs.js:49
result = result.replace(/\[npm]/g, nameExtractionData.npm);
^
TypeError: Cannot read properties of undefined (reading 'replace')
at formatTemplateFileContents (/Users/dalesande/src/auro/test-element/scripts/generateDocs.js:49:19)
at ReadFileContext.callback (/Users/dalesande/src/auro/test-element/scripts/generateDocs.js:87:5)
at FSReqCallback.readFileAfterOpen [as oncomplete] (node:fs:325:13)
Node.js v18.15.0
ERROR: "build:docs" exited with 1.
There was a problem hiding this comment.
In what repo/branch did you see this?
There was a problem hiding this comment.
I generated a new repo using npm run build:test
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #357
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team