Update Node support for app and generated repos #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the generator to not only use the current Node version setting in the package.json to populate the template files with the appropriate node version, but update to support the next LTS version using the new `abstractNodeVersionNext` variable. The updated template files are done to reflect thispolicy https://auro.alaskaair.com/node-support Changes to be committed: modified: .github/settings.yml modified: .github/workflows/testPublish.yml modified: bin/generate.js modified: template/.github/settings.yml modified: template/.github/workflows/testPublish.yml modified: template/package.json
Some MAJOR updates were not addressed that are described in this issue #203 chalk, inquirer and latest-version packages have been updated to the most current version supported by the app. Changes to be committed: modified: package-lock.json modified: package.json
blackfalcon
force-pushed
the
dsande/nodeSupport/431
branch
from
d18e4b4 to
1145b3c
Compare
jason-capsule42
approved these changes
Nov 16, 2023
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #431
Summary:
This commit updates the generator to not only use the current Node version setting in the package.json to populate the template files with the appropriate node version, but update to support the next LTS version using the new
abstractNodeVersionNextvariable.The updated template files are done to reflect this policy https://auro.alaskaair.com/node-support
This PR also updates dependencies and some MAJOR updates were not addressed that are described in this issue
the packages for chalk, inquirer and latest-version packages have been updated to the most current version supported by the app.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team