Tokens referenced in WCSS don't exist in Tokens repo #193
Comments
|
It has been determined by @leeejune that the following breakpoints are deprecated and should be removed from the project.
It is also noted that the breakpoints as defined in WCSS do NOT have supporting tokens and if used they will fail to build the Sass. It is safe to say that these breakpoint definitions are unknown to the public and can be safely removed from the WCSS project. I am transferring this issue to WCSS for the removal of these mixins. |
blackfalcon
added a commit
that referenced
this issue
May 7, 2024
This update removes mixins that were not properly supported by the design tokens that it required as Sass variables. This is NOT a breaking change as, there are no tests to support these mixins and, as stated, there are no variables to support the mixins either, so anyone using this in the public space would not be able to compile the Sass to CSS due to the missing variables. This is the removal of code that should have not been added and is not supported the Auro design guidelines. Changes to be committed: modified: docs/index.html modified: src/_breakpoints.scss
Merged
6 tasks
jason-capsule42
pushed a commit
that referenced
this issue
May 8, 2024
This update removes mixins that were not properly supported by the design tokens that it required as Sass variables. This is NOT a breaking change as, there are no tests to support these mixins and, as stated, there are no variables to support the mixins either, so anyone using this in the public space would not be able to compile the Sass to CSS due to the missing variables. This is the removal of code that should have not been added and is not supported the Auro design guidelines. Changes to be committed: modified: docs/index.html modified: src/_breakpoints.scss
blackfalcon
pushed a commit
that referenced
this issue
May 8, 2024
## [5.1.1](v5.1.0...v5.1.1) (2024-05-08) ### Performance Improvements * remove unused breakpoint mixins [#193](#193) ([d349086](d349086))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please verify the version of Auro design tokens you have installed
@latest
Please describe the bug
See this code - https://github.com/AlaskaAirlines/WebCoreStyleSheets/pull/153/files#diff-0c8f8f9c0b9cd25cedcaace73636c77300422dfc0749b79802dedc3ac43777bb
The added references do not exit in this code
https://github.com/AlaskaAirlines/AuroDesignTokens/blob/03a51144a4d9e9cb5f4c1eb30dfa1273127a4eee/src/breakpoint.json#L1-L28
Reproducing the error
This issue cannot be reproduced on the Auro docsite
Expected behavior
The new mixins added to WCSS should have the following tokens added to the project;
ds-breakpoint-desktopLgds-breakpoint-desktopds-breakpoint-tabletLgds-breakpoint-tabletds-breakpoint-mobileWhat browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Additional context
I am actually confused if these values should be added or the mixins referencing them removed. The work was to update mixins to support new tokens that were already added, but the ones in question were not part of that update.
Exit criteria
If it is decided to remove the new mixins, then this issue needs to be transferred to WCSS for the PR.
This issue can be closed once either the needed tokens are added or the mixins are deleted.
The text was updated successfully, but these errors were encountered: