Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation fail #37

Closed
blackfalcon opened this issue Mar 4, 2020 · 1 comment · Fixed by #40
Closed

Deprecation fail #37

blackfalcon opened this issue Mar 4, 2020 · 1 comment · Fixed by #40
Assignees
@blackfalcon
Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

General Support Request

The current @font-face rule has a deprecation warning, but this is not implemented well.
https://github.com/AlaskaAirlines/OrionWebCoreStyleSheets/blob/master/src/_fonts.scss#L14-L34

It was flushed out that these cannot live side-by-side with new Auro versions as there is a dependency on legacy tokens. Issue #35 was closed out that added logic to address the missign dependency issue.

In recent conversations with @geoffrey1218 it was realized that subsequent code is redundant and having the deprecation warning appar with this code is confusing to engineers.

Possible Solution

  • Remove the deprecation warning
  • Update @font-face rules to logically use the correct variables upon request
@blackfalcon blackfalcon self-assigned this Mar 4, 2020
@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label Mar 11, 2020
blackfalcon added a commit that referenced this issue Mar 11, 2020
@blackfalcon
fix: #37 address deprecation issues
a7e62db
@blackfalcon blackfalcon mentioned this issue Mar 11, 2020
Merged
6 tasks
blackfalcon added a commit that referenced this issue Mar 11, 2020
@blackfalcon
fix: #37 address deprecation issues
de24067
blackfalcon added a commit that referenced this issue Mar 11, 2020
@blackfalcon
fix: #37 address deprecation issues
c995854
blackfalcon added a commit that referenced this issue Mar 11, 2020
@blackfalcon
fix: #37 address deprecation issues
b37d87f
blackfalcon added a commit that referenced this issue Mar 11, 2020
@blackfalcon
fix: #37 address deprecation issues
a2981e1
blackfalcon added a commit that referenced this issue Mar 17, 2020
@blackfalcon
fix: #37 address deprecation issues
2506f37
blackfalcon added a commit that referenced this issue Mar 17, 2020
@blackfalcon
fix: #37 address deprecation issues
2726fbb
blackfalcon added a commit that referenced this issue Mar 17, 2020
@blackfalcon
fix: #37 address deprecation issues
51017df
@blackfalcon blackfalcon linked a pull request Mar 17, 2020 that will close this issue
fix: address deprecation issues #40
Merged
6 tasks
blackfalcon added a commit that referenced this issue Mar 19, 2020
@blackfalcon
fix: #37 address deprecation issues
af7a77f
AuroDesignSystem pushed a commit that referenced this issue Mar 24, 2020
@blackfalcon @AuroDesignSystem
fix: #37 address deprecation issues
4885844
AuroDesignSystem pushed a commit that referenced this issue Mar 24, 2020
@semantic-release-bot
chore(release): 2.8.13 [skip ci]
e23c728 
## [2.8.13](v2.8.12...v2.8.13) (2020-03-24)

### Bug Fixes

* [#37](#37) address deprecation issues ([4885844](4885844))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 2.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
released Completed work has been released Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: address deprecation issues AlaskaAirlines/WebCoreStyleSheets
2 participants
@blackfalcon @AuroDesignSystem