Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new list styles #120

Closed
wants to merge 0 commits into from
Closed

feat: added new list styles #120

wants to merge 0 commits into from

Conversation

jrbromberg
Copy link
Contributor

@jrbromberg jrbromberg commented Sep 23, 2022

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #115

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2022

CLA assistant check
All committers have signed the CLA.

@blackfalcon
Copy link
Member

Hi @jrbromberg is this a PR you are actively working on?

Just some early feedback, please be sure to read through our Contributing Guidelines prior to submitting a formal PR. Specifically,

Also, please consult with @leeejune regarding any specifications with type layout and bulleted lists currently supported by the design system.

Thanks for the contribution.

@leeejune
Copy link
Contributor

Consulted with Julieta (UI designer) and Brandon and decided that the space between the bullet and text should be 8px.

@blackfalcon
Copy link
Member

I am removing myself as a reviewer as this PR is in a state of flux. Please let me know when the PR is ready for final review.

Also, there should be an issue created prior to review as to what this work is addressing and the design spec that it is supporting.

@blackfalcon blackfalcon removed their request for review September 29, 2022 16:44
@jrbromberg jrbromberg closed this Nov 18, 2022
@jrbromberg jrbromberg deleted the jbrom/ulandolstyling/#115 branch November 18, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants