fix(styles): fix the auro capitalize function #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
blackfalcon
requested changes
Apr 20, 2023
blackfalcon
previously approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Everything works great! Thanks @marnel-mangrubang and @chethanayasa
I tested this with a local version of the Auro docsite and all green lights!
|
@marnel-mangrubang and @chethanayasa please make sure to agree to the CLA. It's part of the OSS agreement with this project. |
marnel-mangrubang
force-pushed
the
marnel-mangrubang/CapitalizeFunctionCausingBuildError/#148
branch
from
21edb1f to
cdfaac4
Compare
blackfalcon
approved these changes
Apr 24, 2023
blackfalcon
deleted the
marnel-mangrubang/CapitalizeFunctionCausingBuildError/#148
branch
|
🎉 This PR is included in version 4.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
This PR is to address the AuroDocSite failing to build with the use of version 4.3.0 of WCSS. Due to the addition of numbers in the
$auro-spacing-optionsdefault value, theauro_capitalizefunction inside of utilityFunctions would throw an error because its always expecting the argument type to be string. This PR is to unblock another story on our board relating to the AuroDocSite repo.Fixes: #148
Summary:
auro_capitalizefunction to only capitalize if string type. If number type, return string version of that number without capitalizing.auro_map-deep-getto always be string so that it can find the value of the matching string key from the collection of tokens.spacing.specto account for number values.Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team