-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply latest token ds-auro-icon-size #66 #67
Conversation
Reviewer's Guide by SourceryThis PR updates the icon styling to use the new Class diagram for updated icon stylingclassDiagram
class IconStyling {
--ds-auro-icon-size: String
position: String
top: String
left: String
}
note for IconStyling "Updated to use --ds-auro-icon-size design token instead of width property"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes to iconVersion.js appear incomplete - please clarify the intended modification to this file.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with how the tail icon is now rendering. If you compare the localhost tail icons to the one on the docsite, you can see that some of the icon is cut off.
I think the issue is tied to the fact that we now use the --ds-auro-icon-size
token for now both the height and width, when previously the 118%
was only allocated towards width in this repo.
Ended up having change all the values to make it match the existing styles of released version on docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to run build to update min.js
files
Built it before pushing. But I double checked in case I missed something. No changes to push after rebuild. |
7aa8993
to
d67a4ef
Compare
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Enhancements: