Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest token ds-auro-icon-size #66 #67

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Oct 28, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhancements:

  • Update the CSS to use a CSS variable for icon size, improving maintainability.

@rmenner rmenner self-assigned this Oct 28, 2024
@rmenner rmenner requested a review from a team as a code owner October 28, 2024 23:44
Copy link

sourcery-ai bot commented Oct 28, 2024

Reviewer's Guide by Sourcery

This PR updates the icon styling to use the new --ds-auro-icon-size design token instead of directly setting the width property. The change maintains the same visual appearance while adopting the design system's token-based approach.

Class diagram for updated icon styling

classDiagram
    class IconStyling {
        --ds-auro-icon-size: String
        position: String
        top: String
        left: String
    }
    note for IconStyling "Updated to use --ds-auro-icon-size design token instead of width property"
Loading

File-Level Changes

Change Details Files
Replace direct width property with design token for icon sizing
  • Added --ds-auro-icon-size custom property with value of 118%
  • Removed explicit width: 118% declaration
src/style.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rmenner rmenner linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The changes to iconVersion.js appear incomplete - please clarify the intended modification to this file.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

demo/api.min.js Outdated Show resolved Hide resolved
demo/api.min.js Outdated Show resolved Hide resolved
demo/index.min.js Outdated Show resolved Hide resolved
demo/index.min.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with how the tail icon is now rendering. If you compare the localhost tail icons to the one on the docsite, you can see that some of the icon is cut off.

I think the issue is tied to the fact that we now use the --ds-auro-icon-size token for now both the height and width, when previously the 118% was only allocated towards width in this repo.

@rmenner
Copy link
Contributor Author

rmenner commented Oct 30, 2024

There is an issue with how the tail icon is now rendering. If you compare the localhost tail icons to the one on the docsite, you can see that some of the icon is cut off.

I think the issue is tied to the fact that we now use the --ds-auro-icon-size token for now both the height and width, when previously the 118% was only allocated towards width in this repo.

Ended up having change all the values to make it match the existing styles of released version on docs

Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run build to update min.js files

@rmenner
Copy link
Contributor Author

rmenner commented Oct 31, 2024

Need to run build to update min.js files

Built it before pushing. But I double checked in case I missed something. No changes to push after rebuild.

@jordanjones243 jordanjones243 force-pushed the rmenner/bugfix/icon-customsize branch from 7aa8993 to d67a4ef Compare November 1, 2024 16:52
@jordanjones243 jordanjones243 merged commit 952df63 into main Nov 1, 2024
6 checks passed
@jordanjones243 jordanjones243 deleted the rmenner/bugfix/icon-customsize branch November 1, 2024 16:54
@blackfalcon
Copy link
Member

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-avatar: new icon token
3 participants