Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTI-GITTER PR: migration github-config-and-gitignore-changes #71

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Dec 16, 2024

Summary by Sourcery

Revise contribution guidelines to improve clarity and process adherence, update CI workflows for better branch management, and add a new deployment workflow for demo automation.

CI:

  • Modify the testPublish.yml workflow to ensure it triggers on pushes and pull requests to the main and beta branches, and update the node version specification.

Deployment:

  • Introduce a new workflow publishDemo.yml to automate the deployment of demos on pull requests to the main branch.

Documentation:

  • Update the CONTRIBUTING.md to include more detailed guidelines for submitting issues and pull requests, emphasizing the importance of consulting with the Auro team before starting work.

@rmenner rmenner requested a review from a team as a code owner December 16, 2024 17:01
Copy link

sourcery-ai bot commented Dec 16, 2024

Reviewer's Guide by Sourcery

This PR updates various GitHub configuration files and templates to improve the contribution process and repository management. The changes include updates to issue templates, workflow configurations, and documentation files to align with current best practices.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enhanced contribution guidelines with clearer instructions and process improvements
  • Added link to Innersourcing Flow Guide for Alaska Airlines employees
  • Updated issue submission process with clearer instructions
  • Added 48-hour response time expectation
  • Added guidance about consulting with Auro team before starting work
  • Enhanced git workflow instructions, particularly around rebasing
.github/CONTRIBUTING.md
Improved issue templates and repository settings
  • Updated issue templates with better formatting and labels
  • Added exit criteria section to issue templates
  • Enabled automatic branch deletion on merge
  • Added new UI Update label type
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
.github/settings.yml
Updated GitHub workflow configurations
  • Added new demo publishing workflow
  • Improved conditional logic in test and publish workflow
  • Updated Node.js version specifications
.github/workflows/publishDemo.yml
.github/workflows/testPublish.yml
.github/workflows/codeql.yml
Code of Conduct updates and maintenance
  • Removed specific contact email
  • Updated formatting and structure
  • Clarified enforcement procedures
.github/CODE_OF_CONDUCT.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jason-capsule42 jason-capsule42 merged commit 8f9dee4 into main Dec 20, 2024
6 of 7 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/github-config-and-gitignore-changes branch December 20, 2024 20:29
@blackfalcon
Copy link
Member

🎉 This PR is included in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants