Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons are not rendering for iconOnly buttons #245

Closed
jordanjones243 opened this issue Feb 12, 2024 · 0 comments · Fixed by #246
Closed

Icons are not rendering for iconOnly buttons #245

jordanjones243 opened this issue Feb 12, 2024 · 0 comments · Fixed by #246
Assignees
@jordanjones243
Labels
auro-button Type: Bug Bug or Bug fixes

Comments

@jordanjones243
Copy link
Contributor

Please verify the version of auro-button you have installed

7.2.6

Please describe the bug

  1. Go to https://auro.alaskaair.com/components/auro/button/api#gsc.tab=0
  2. Scroll down to "Icon only" examples
  3. See error

Reproducing the error on the docsite

This issue is reproducible on the Auro docsite

Expected behavior

Icons are rendered on correctly on the docsite

What browsers are you seeing the problem on?

Chrome

Additional context

This bug is coming from the incorrect use of the customSize attribute on the auro-icon being used in the iconOnly buttons.

Exit criteria

Icons render correctly on the iconOnly buttons
@jordanjones243 jordanjones243 self-assigned this Feb 12, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Feb 13, 2024
@Patrick-Daly-AA Patrick-Daly-AA mentioned this issue Feb 13, 2024
Closed
jordanjones243 added a commit that referenced this issue Feb 13, 2024
@jordanjones243
fix(slim): render icon in icononly slim example #245
6ad671d
@jordanjones243 jordanjones243 mentioned this issue Feb 13, 2024
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Feb 13, 2024 that will close this issue
Fix icon rendering issue #246
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue Feb 14, 2024
@jordanjones243 @blackfalcon
fix(slim): render icon in icononly slim example #245
380e8c0
blackfalcon pushed a commit that referenced this issue Feb 14, 2024
@semantic-release-bot
chore(release): 7.2.7 [skip ci]
5ae951d 
## [7.2.7](v7.2.6...v7.2.7) (2024-02-14)

### Bug Fixes

* **slim:** render icon in icononly slim example [#245](#245) ([380e8c0](380e8c0))

### Performance Improvements

* **demo:** update demofile name ([f11d9c5](f11d9c5))
* **examples:** update references to example files ([47bff95](47bff95))
* **jsdocs:** update event jsdocs ([954dbb4](954dbb4))
* **styles:** update styles for icon only buttons ([99f5488](99f5488))
* update dependencies ([83b4486](83b4486))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-button Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix icon rendering issue AlaskaAirlines/auro-button
2 participants
@jordanjones243 @Patrick-Daly-AA