Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect hover behavior with disabled button #256

Closed
blackfalcon opened this issue Jul 5, 2024 · 0 comments · Fixed by #258
Closed

Incorrect hover behavior with disabled button #256

blackfalcon opened this issue Jul 5, 2024 · 0 comments · Fixed by #258
Assignees
@jordanjones243
Labels
auro-button Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

Please verify the version of auro-button you have installed

@latest

Please describe the bug

  1. Go to https://auro.alaskaair.com/components/auro/button/api
  2. Find disabled example
  3. Hover over the disabled button
  4. See Incorrect hover UI

Jul-05-2024 15-00-52

Reproducing the error on the docsite

This issue is reproducible on the Auro docsite

Expected behavior

A disabled button should NOT have an active button hover UI.

What browsers are you seeing the problem on?

No response

Additional context

It is validated that this bug appeared between @aurodesignsystem/auro-button@7.2.1 and @aurodesignsystem/auro-button@7.2.2

v7.2.1...v7.2.2#diff-c0a5ddd5b365322730802e8cb15c95c3b6e965cbd3e569c69a2f089753844cdb

Exit criteria

This issue can be closed once the hover UI is adjusted to the correct UI spec.
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members auro-button labels Jul 5, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jul 8, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Jul 8, 2024
jordanjones243 added a commit that referenced this issue Jul 8, 2024
@jordanjones243
fix(hover): remove disabled hover UI #256
4a0d84f
@blackfalcon blackfalcon linked a pull request Jul 8, 2024 that will close this issue
Remove disabled hover UI #258
Merged
6 tasks
@blackfalcon blackfalcon mentioned this issue Jul 8, 2024
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 8, 2024
@jordanjones243 @blackfalcon
fix(hover): remove disabled hover UI #256
13fd26b
blackfalcon pushed a commit that referenced this issue Jul 8, 2024
@semantic-release-bot
chore(release): 7.2.10 [skip ci]
f2aa39a 
## [7.2.10](v7.2.9...v7.2.10) (2024-07-08)

### Bug Fixes

* **hover:** remove disabled hover UI [#256](#256) ([13fd26b](13fd26b))
DukeFerdinand pushed a commit that referenced this issue Aug 22, 2024
@jordanjones243 @DukeFerdinand
fix(hover): remove disabled hover UI #256
22da519
DukeFerdinand pushed a commit that referenced this issue Aug 22, 2024
@semantic-release-bot @DukeFerdinand
chore(release): 7.2.10 [skip ci]
c55f5ac 
* **hover:** remove disabled hover UI [#256](#256) ([13fd26b](13fd26b))
jason-capsule42 pushed a commit that referenced this issue Sep 10, 2024
@jordanjones243 @jason-capsule42
fix(hover): remove disabled hover UI #256
a46ac93
jason-capsule42 pushed a commit that referenced this issue Sep 10, 2024
@semantic-release-bot @jason-capsule42
chore(release): 7.2.10 [skip ci]
af0b6e0 
* **hover:** remove disabled hover UI [#256](#256) ([13fd26b](13fd26b))
blackfalcon pushed a commit that referenced this issue Sep 10, 2024
@semantic-release-bot
chore(release): 7.3.0-beta.7 [skip ci]
4cb2b28 
# [7.3.0-beta.7](v7.3.0-beta.6...v7.3.0-beta.7) (2024-09-10)

### Bug Fixes

* **hover:** remove disabled hover UI [#256](#256) ([a46ac93](a46ac93))

### Features

* **themes:** update styles to support component themes [#243](#243) ([f307e92](f307e92))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-button Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove disabled hover UI AlaskaAirlines/auro-button
3 participants
@blackfalcon @jordanjones243 @Patrick-Daly-AA