-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add register static method #268
Conversation
Reviewer's Guide by SourceryThis pull request adds a new static Class diagram for AuroButton with new register methodclassDiagram
class AuroButton {
+static register(name="auro-button")
+connectedCallback()
+disconnectedCallback()
+attributeChangedCallback(name, oldValue, newValue)
+focus()
+blur()
+click()
+render()
}
note for AuroButton "New static method 'register' added to simplify component registration"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider keeping the default registration in addition to the new
register
method to maintain backward compatibility. This ensures existing implementations continue to work while providing the new flexibility. - Update the documentation to clearly explain both the default registration and the new
register
method, including when and why a user might choose one over the other.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
12a9bc8
to
2111a6f
Compare
AuroButton.register is to easily register the element without extra importing `import '@aurodesignsystem/auro-button'` will still register this element to `<auro-button>` `import { AuroButton } from '../src/auro-button.js'` wont register this element until `AuroButton.register` gets called
2111a6f
to
fd8cb60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files generated during the build are not checked in.
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #267
Summary:
AuroButton.register is to easily register the element without extra importing
import '@aurodesignsystem/auro-button'
will still register this element to<auro-button>
import { AuroButton } from '../src/auro-button.js'
wont register this element untilAuroButton.register
gets calledType of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add a static method AuroButton.register to facilitate the registration of the AuroButton element with a custom name, replacing the previous default registration approach. Update documentation and tests to align with this new method.
New Features:
Enhancements:
Documentation:
Tests: