-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add class for auro-button with correct pattern auroButton #282 #283
Conversation
Reviewer's Guide by SourceryThis PR adds a new CSS class 'auroButton' to the AuroButton component while maintaining existing functionality. The change is focused on performance optimization by introducing a class name that follows the correct naming pattern. Class diagram for AuroButton with new CSS classclassDiagram
class AuroButton {
+util_insetLg--squish: boolean
+auro-button: boolean
+auroButton: boolean
+auro-button--rounded: boolean
+auro-button--slim: boolean
+auro-button--iconOnly: boolean
}
note for AuroButton "Added new CSS class 'auroButton' for performance optimization"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please remove the 'auroButton' class addition and maintain the existing kebab-case naming convention ('auro-button'). If there's a specific reason for needing a camelCase version, please provide context in the PR description.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 8.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Enhancements: