Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add class for auro-button with correct pattern auroButton #282 #283

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Dec 18, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhancements:

  • Add 'auroButton' class to the AuroButton component for improved pattern consistency.

@rmenner rmenner self-assigned this Dec 18, 2024
@rmenner rmenner requested a review from a team as a code owner December 18, 2024 22:15
Copy link

sourcery-ai bot commented Dec 18, 2024

Reviewer's Guide by Sourcery

This PR adds a new CSS class 'auroButton' to the AuroButton component while maintaining existing functionality. The change is focused on performance optimization by introducing a class name that follows the correct naming pattern.

Class diagram for AuroButton with new CSS class

classDiagram
    class AuroButton {
        +util_insetLg--squish: boolean
        +auro-button: boolean
        +auroButton: boolean
        +auro-button--rounded: boolean
        +auro-button--slim: boolean
        +auro-button--iconOnly: boolean
    }
    note for AuroButton "Added new CSS class 'auroButton' for performance optimization"
Loading

File-Level Changes

Change Details Files
Added a new CSS class to the button component's class list
  • Added 'auroButton' class to the classes object in the component's class computation logic
  • Maintained all existing class assignments and functionality
src/auro-button.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rmenner rmenner linked an issue Dec 18, 2024 that may be closed by this pull request
Copy link

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please remove the 'auroButton' class addition and maintain the existing kebab-case naming convention ('auro-button'). If there's a specific reason for needing a camelCase version, please provide context in the PR description.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rmenner rmenner merged commit 6a0e67e into main Dec 19, 2024
6 of 7 checks passed
@rmenner rmenner deleted the rmenner/include-latest-class-pattern branch December 19, 2024 03:18
@blackfalcon
Copy link
Member

🎉 This PR is included in version 8.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-button: enable the use of the correct css class pattern
3 participants