-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move theming support from Beta to Main #50
Conversation
|
Reviewer's Guide by SourceryThis pull request moves theming support from Beta to Main for the auro-carousel component. The changes primarily focus on implementing tier 3 tokens for theming support and introducing custom versioned Auro components. The main modifications include updating the styling in SCSS, refactoring the JavaScript code to use new versioning and button/icon components, and updating the documentation. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please clarify the reasoning behind removing some of the specific styles in the CSS? How does this affect the overall appearance and functionality of the carousel?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
BREAKING CHANGE: trigger major release for color theme support #44
Surge demo deployment failed! 😭 |
# [3.0.0-beta.1](v2.3.0-beta.1...v3.0.0-beta.1) (2024-09-26) ### Features * add tag name as attribute when custom registered ([75d36cb](75d36cb)) ### Performance Improvements * refactor custom component registration config ([c006e6f](c006e6f)) * update dependencies ([e16223e](e16223e)) ### BREAKING CHANGES * trigger major release for color theme support #44
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #44
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Move theming support from beta to main by implementing tier 3 tokens and introduce custom versioning for auro components. Refactor the carousel component to utilize versioned tags for auro-button and auro-icon. Update documentation to remove outdated CSS fallback information and reflect the new component version.
New Features:
Enhancements:
Documentation: