Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming support from Beta to Main #50

Merged
merged 11 commits into from
Sep 30, 2024
Merged

Move theming support from Beta to Main #50

merged 11 commits into from
Sep 30, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 14, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #44

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Move theming support from beta to main by implementing tier 3 tokens and introduce custom versioning for auro components. Refactor the carousel component to utilize versioned tags for auro-button and auro-icon. Update documentation to remove outdated CSS fallback information and reflect the new component version.

New Features:

  • Introduce theming support by implementing tier 3 tokens, moving them from beta to main.
  • Add custom versioning for auro components, allowing for dynamic tag generation.

Enhancements:

  • Refactor the carousel component to use versioned auro-button and auro-icon tags for better modularity and maintainability.

Documentation:

  • Remove outdated information about CSS custom property fallbacks from the README.
  • Update the README to reflect the new version of auro-carousel.

@jordanjones243 jordanjones243 self-assigned this Aug 14, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner August 14, 2024 18:04
@jordanjones243 jordanjones243 linked an issue Aug 14, 2024 that may be closed by this pull request
2 tasks
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jordanjones243
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sourcery-ai bot commented Aug 14, 2024

Reviewer's Guide by Sourcery

This pull request moves theming support from Beta to Main for the auro-carousel component. The changes primarily focus on implementing tier 3 tokens for theming support and introducing custom versioned Auro components. The main modifications include updating the styling in SCSS, refactoring the JavaScript code to use new versioning and button/icon components, and updating the documentation.

File-Level Changes

Files Changes
src/style.scss Removed gradient and specific styling for carousel buttons, likely to be replaced by the new button component
src/auro-carousel.js
src/buttonVersion.js
src/iconVersion.js
Introduced custom versioning for Auro components, specifically for buttons and icons
src/auro-carousel.js Refactored button elements to use the new Auro button component with specific attributes
src/auro-carousel.js Updated icon generation to work with the new Auro icon component
README.md Removed CSS custom property fallbacks from the README
README.md Updated the CDN link to the new beta version of auro-carousel
CHANGELOG.md Added new entries to the CHANGELOG for the beta release

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please clarify the reasoning behind removing some of the specific styles in the CSS? How does this affect the overall appearance and functionality of the carousel?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/auro-carousel.js Show resolved Hide resolved
src/auro-carousel.js Show resolved Hide resolved
Copy link

github-actions bot commented Sep 26, 2024

Surge demo deployment failed! 😭

# [3.0.0-beta.1](v2.3.0-beta.1...v3.0.0-beta.1) (2024-09-26)

### Features

* add tag name as attribute when custom registered ([75d36cb](75d36cb))

### Performance Improvements

* refactor custom component registration config ([c006e6f](c006e6f))
* update dependencies ([e16223e](e16223e))

### BREAKING CHANGES

* trigger major release for color theme support #44
@jason-capsule42 jason-capsule42 merged commit a90a944 into main Sep 30, 2024
8 of 10 checks passed
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
5 participants