-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address tech debt #52
Conversation
BREAKING CHANGE: trigger major release for color theme support #44
Reviewer's Guide by SourceryThis pull request addresses technical debt by refactoring the component registration process, updating dependencies, and modernizing the project structure. The changes primarily focus on improving the way the AuroCarousel component is registered and used, as well as updating various configuration files and documentation. Sequence DiagramsequenceDiagram
participant App
participant RuntimeUtils
participant CustomElements
App->>RuntimeUtils: registerComponent('custom-carousel', AuroCarousel)
RuntimeUtils->>CustomElements: define('custom-carousel', AuroCarousel)
CustomElements-->>RuntimeUtils: Component registered
RuntimeUtils-->>App: Registration complete
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide context for the removal of scripts/generateDocs.mjs and scripts/postCss.mjs. How is their functionality being handled now?
- Consider measuring and documenting the performance impact of the new component registration approach, particularly on bundle size and initialization time.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: # (issue, if applicable)
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Refactor the component registration process to utilize RuntimeUtils, update documentation accordingly, and clean up obsolete scripts and dependencies.
Enhancements:
Documentation:
Chores: