Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS token per new design system theming capability #59

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

fajar-apri-alaska
Copy link
Contributor

@fajar-apri-alaska fajar-apri-alaska commented Nov 9, 2023

Alaska Airlines Pull Request

Resolves: #58

Summary:

  • Update the design tokens to reflect the new theming conventions regarding tokens from the AuroDesignTokens and JetstreamDesignTokens repo.

Type of change:

Please delete options that are not relevant.

  • Revision of an existing capability

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

- add fallback values for the tokens

Changes to be committed:
	modified:   demo/demo.md
	modified:   docs/index.html
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-flight-segment.scss
	modified:   src/style-flightline.scss
@fajar-apri-alaska fajar-apri-alaska requested a review from a team as a code owner November 9, 2023 05:56
@fajar-apri-alaska fajar-apri-alaska self-assigned this Nov 9, 2023
@fajar-apri-alaska fajar-apri-alaska linked an issue Nov 9, 2023 that may be closed by this pull request
@fajar-apri-alaska
Copy link
Contributor Author

Hi @blackfalcon, I think auro-badge WCSS peer dependency here needs to be updated as well to 5.0.4 for this ci git action to pass.
Please correct me if I'm wrong.

Copy link
Member

@jason-capsule42 jason-capsule42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cna not be merged while the tests are failing. Please resolve the testing.

@fajar-apri-alaska
Copy link
Contributor Author

fajar-apri-alaska commented Nov 13, 2023

PR is currently BLOCKED until below PR is accepted, merged and shipped.

@fajar-apri-alaska fajar-apri-alaska marked this pull request as draft November 13, 2023 05:47
@blackfalcon
Copy link
Member

The auro-badge blocking issue has been resolved. All dependencies have been updated as well as node support.

docs/index.html Show resolved Hide resolved
@fajar-apri-alaska fajar-apri-alaska marked this pull request as ready for review November 29, 2023 03:27
This commit updates dependencies, including the blocker from auro-badge
that had a conflict with peer dependencies.

This commit also updates the repo to support the new Node support
policy.

Changes to be committed:
modified:   .github/settings.yml
modified:   .github/workflows/testPublish.yml
modified:   package-lock.json
modified:   package.json
@blackfalcon blackfalcon force-pushed the fajarapri/updateCSSToken/#58 branch from 66ad30c to 71ea254 Compare December 2, 2023 02:54
@blackfalcon blackfalcon merged commit 4a9f3f4 into main Dec 2, 2023
4 checks passed
@blackfalcon blackfalcon deleted the fajarapri/updateCSSToken/#58 branch December 2, 2023 02:56
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-flightline: Theming Support
3 participants