Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Testing into Monorepo #85

Open
chrisfalaska opened this issue Dec 4, 2024 · 4 comments
Open

Integrate Testing into Monorepo #85

chrisfalaska opened this issue Dec 4, 2024 · 4 comments

Comments

@chrisfalaska
Copy link
Contributor

chrisfalaska commented Dec 4, 2024

Please verify the version of auro-form you have installed

1.5.0

Please describe the bug

In the new monorepo structure, running npm run test fails.

For independent component packages that do not have dependencies on other component packages in auro-formkit, the tests pass.

However, for components with auro-formkit dependencies, such as combobox, the tests will fail:

Error while generating code coverage for http://localhost:8000/__wds-outside-root__/1/input/dist/index.js.
@auro-formkit/auro-datepicker:test: Error: ENOENT: no such file or directory, open '/Users/AlaskaUser/Dev/auro-form/components/datepicker/__wds-outside-root__/1/input/dist/index.js'

The issue seems to be with the URL Web Test Runner generates, specifically:

__wds-outside-root__

This may be related to these issues:

Expected behavior

wtr should not fail when running tests that depend on other component packages within auro-formkit.

Additional context

#19

@chrisfalaska chrisfalaska added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes and removed not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Dec 4, 2024
@chrisfalaska
Copy link
Contributor Author

Currently blocked by #19 until merged.

@chrisfalaska chrisfalaska changed the title Integrate Testing to Monorepo Integrate Testing into Monorepo Dec 4, 2024
@chrisfalaska
Copy link
Contributor Author

Be sure to return test to the .husky/pre-commit file:

./node_modules/.bin/npm-run-all preCommit test lint postinstall

@jordanjones243
Copy link
Contributor

Interesting observation while trying to repro this... auro-select, which is dependent on both menu, passes it's test. Funnily enough, that same error message pops up during the process. Hard to say whether the error message listed in the issue is the actual problem with combobox and datepicker.

@jordanjones243 jordanjones243 removed their assignment Dec 13, 2024
@jordanjones243
Copy link
Contributor

After further investigation, the error listed in this ticket is not what is causing the tests to fail. Upon further investigation, one of there are bugs causing datepicker and combobox's tests to fail and will be addressed in a separate ticket. The work in this ticket will be to track down what is causing the wds-root errors at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants