Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-formkit: Add Turborepo & Convert to Monorepo #84

Merged
merged 127 commits into from
Dec 4, 2024
Merged

Conversation

chrisfalaska
Copy link
Contributor

@chrisfalaska chrisfalaska commented Dec 4, 2024

auro-formkit Monorepo

Creates a new auro-formkit repository, powered by Turborepo and transforms auro-form into a monorepo.

Summary

  • Convert the project to a monorepo using Turborepo, reorganizing components and packages under a unified structure.

  • Update build scripts and dependencies to support the new architecture.

  • Introduce TypeScript support for enhanced development experience.

  • Initial documentation added (will further be developed in Integrate Custom formkit README Docs Processor #11 ).

New Features:

  • Introduce Turborepo to manage the monorepo structure, allowing for efficient handling of multiple packages within the repository.

Enhancements:

  • Convert the project to a monorepo structure, organizing components and packages under a unified repository.
  • Update package dependencies and scripts to align with the new monorepo structure, ensuring compatibility and streamlined operations.
  • Enable TypeScript support across various components, enhancing type safety and developer experience.

Build:

  • Add a new turbo.json configuration file to manage build tasks and dependencies across the monorepo.
  • Introduce shared build tools and configurations for consistent build processes across components.

Getting Started

Install

npm i

Build

npm run build

Dev

npm run dev

Lint

npm run lint

Testing

npm run test

For this PR, test is currently a work in progress and is failing.

Further development will continue in #85

@chrisfalaska chrisfalaska changed the title Add Turborepo & Convert to Monorepo auro-formkit: Add Turborepo & Convert to Monorepo Dec 4, 2024
@chrisfalaska chrisfalaska marked this pull request as ready for review December 4, 2024 18:28
@chrisfalaska chrisfalaska requested a review from a team as a code owner December 4, 2024 18:28
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisfalaska - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Tests are currently failing - please ensure these are fixed in the follow-up work tracked in Integrate Testing into Monorepo #85. Having a solid test suite will be critical for maintaining quality across the monorepo.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev and Build works! Great job!

Copy link
Contributor

@sun-mota sun-mota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please fix husky pre-commit to remove test, linters should be changed to lint
    We can add back test to the pre-commit, on the PR for fixing test,
  2. I don't see dist folder under root. was it intentional?

@chrisfalaska
Copy link
Contributor Author

  1. Please fix husky pre-commit to remove test, linters should be changed to lint
    We can add back test to the pre-commit, on the PR for fixing test,
  2. I don't see dist folder under root. was it intentional?

Changes made here:
https://github.com/AlaskaAirlines/auro-form/pull/84/files/3d3a598dbc96ebb0c78cde8cf8c08573b0ab5625..5a8853d959db2120b890bb3b8ac8498480b761e3

I also left a note to return test to Husky pre-commit here:
#85 (comment)

@chrisfalaska chrisfalaska requested a review from sun-mota December 4, 2024 20:14
Copy link
Contributor

@sun-mota sun-mota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build, dev and commit work.
Approve with known issues: publish process, test

@chrisfalaska
Copy link
Contributor Author

  1. Please fix husky pre-commit to remove test, linters should be changed to lint
    We can add back test to the pre-commit, on the PR for fixing test,
  2. I don't see dist folder under root. was it intentional?

re: the root dist folder, I created a ticket for the NPM/CDN publishing integration: #87

@chrisfalaska chrisfalaska merged commit 47b0af5 into main Dec 4, 2024
3 of 6 checks passed
@chrisfalaska chrisfalaska deleted the cfriedberg/19 branch December 4, 2024 21:49
@rmenner
Copy link
Contributor

rmenner commented Dec 16, 2024

🎉 This PR is included in version 1.6.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants