-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auro-formkit
: Add Turborepo & Convert to Monorepo
#84
Conversation
auro-formkit
: Add Turborepo & Convert to Monorepo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chrisfalaska - I've reviewed your changes - here's some feedback:
Overall Comments:
- Tests are currently failing - please ensure these are fixed in the follow-up work tracked in Integrate Testing into Monorepo #85. Having a solid test suite will be critical for maintaining quality across the monorepo.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev
and Build
works! Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please fix husky pre-commit to remove test, linters should be changed to lint
We can add back test to the pre-commit, on the PR for fixing test, - I don't see dist folder under root. was it intentional?
Changes made here: I also left a note to return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build, dev and commit work.
Approve with known issues: publish process, test
re: the root |
🎉 This PR is included in version 1.6.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
auro-formkit
MonorepoCreates a new
auro-formkit
repository, powered by Turborepo and transformsauro-form
into a monorepo.Summary
Convert the project to a monorepo using Turborepo, reorganizing components and packages under a unified structure.
Update build scripts and dependencies to support the new architecture.
Introduce TypeScript support for enhanced development experience.
Initial documentation added (will further be developed in Integrate Custom formkit README Docs Processor #11 ).
New Features:
Enhancements:
Build:
turbo.json
configuration file to manage build tasks and dependencies across the monorepo.Getting Started
Install
Build
Dev
Lint
Testing
For this PR,
test
is currently a work in progress and is failing.Further development will continue in #85