Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add space between bib and trigger #56 #104

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sun-mota
Copy link
Contributor

@sun-mota sun-mota commented Dec 13, 2024

Alaska Airlines Pull Request

closes #56

blueprint: https://www.figma.com/design/3TQhiKjQqQOKYqaqcO1zj2/Dropdown?node-id=1231-21886&node-type=rounded_rectangle&m=dev
spacing should be auro-size-50
image

Before Submitting this pull request:

  • Link all tickets in this repository related to this PR in the Development section
    note: all pull requests require at least one linked ticket
  • If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Bug Fixes:

  • Add margin-top to bibStyles.scss to ensure proper spacing between bib and trigger elements.

@sun-mota sun-mota requested a review from a team as a code owner December 13, 2024 17:41
@sun-mota sun-mota self-assigned this Dec 13, 2024
Copy link

sourcery-ai bot commented Dec 13, 2024

Reviewer's Guide by Sourcery

This PR adds spacing between the bib (base component) and trigger elements in dropdown-related components by adding a margin-top CSS property. The change is implemented through a SCSS style update, using a design system token variable for consistent spacing.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added vertical spacing between bib and trigger elements
  • Added margin-top using design system token var(--ds-size-50) with fallback to $ds-size-50
components/dropdown/src/styles/bibStyles.scss
Updated minified demo files
  • Regenerated minified JavaScript files for component demos
components/combobox/demo/api.min.js
components/combobox/demo/index.min.js
components/datepicker/demo/api.min.js
components/datepicker/demo/index.min.js
components/dropdown/demo/api.min.js
components/dropdown/demo/index.min.js
components/select/demo/api.min.js
components/select/demo/index.min.js

Assessment against linked issues

Issue Objective Addressed Explanation
#56 Add 4px spacing between the dropdown trigger and bib to match blueprint design

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sun-mota - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding *.min.js to your .gitignore to avoid including generated files in the PR diff
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sun-mota sun-mota force-pushed the sunMota/bib-trigger-space/56 branch from 2aa2fc4 to 34ff7bc Compare December 13, 2024 17:48
Copy link
Contributor

@chrisfalaska chrisfalaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sun-mota sun-mota merged commit d936fd4 into main Dec 13, 2024
4 of 6 checks passed
@sun-mota sun-mota deleted the sunMota/bib-trigger-space/56 branch December 13, 2024 22:22
@rmenner
Copy link
Contributor

rmenner commented Dec 16, 2024

🎉 This PR is included in version 1.6.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DROPDOWN: Add padding between the trigger and bib
3 participants