Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example of inline-block size #105

Closed
wants to merge 4 commits into from

Conversation

sun-mota
Copy link
Contributor

@sun-mota sun-mota commented Dec 13, 2024

Alaska Airlines Pull Request

closes #57

Before Submitting this pull request:

  • Link all tickets in this repository related to this PR in the Development section
    note: all pull requests require at least one linked ticket
  • If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Documentation:

  • Add a new example demonstrating the use of inline-block size for auro-dropdown components, showcasing different configurations such as icon only, text only, and text with icon.

Copy link

sourcery-ai bot commented Dec 13, 2024

Reviewer's Guide by Sourcery

This PR updates the dropdown component documentation by replacing the aria-labelledby example with a new example demonstrating how to create inline-block dropdowns with different trigger styles (icon-only, text-only, and text with icon). The implementation includes adding the necessary auro-icon script and creating a new example file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new example for inline-block dropdown implementation
  • Created new example showing three dropdown variants: icon-only, text-only, and text with icon
  • Added display: inline-block styling to match dropdown width with trigger content
  • Implemented white-space: nowrap to prevent trigger text wrapping
components/dropdown/apiExamples/ineline.html
Updated documentation structure and content
  • Removed aria-labelledby example section
  • Added new section 'Common use with its width matching the trigger'
  • Updated example descriptions and implementation details
components/dropdown/demo/index.md
components/dropdown/docs/partials/index.md
Added required dependency for new functionality
  • Added auro-icon script import for icon support in dropdown examples
components/dropdown/demo/index.html

Assessment against linked issues

Issue Objective Addressed Explanation
#57 Add examples of dropdowns with trigger width matching content size
#57 Include examples with both default trigger and auro-icon trigger

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sun-mota sun-mota force-pushed the sunMota/inline-example/57 branch from 4ebd62f to 4b052f9 Compare December 16, 2024 16:16
@sun-mota sun-mota changed the title docs: add example of inelin-block size docs: add example of inline-block size Dec 16, 2024
@sun-mota sun-mota force-pushed the sunMota/inline-example/57 branch from 4b052f9 to c59ae98 Compare December 16, 2024 20:01
@sun-mota sun-mota closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DROPDOWN: Create inline-block trigger examples to match blueprint
2 participants