Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #137

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and revise contributing guidelines.

Build:

  • Update Node to v22.

CI:

  • Update CI to test on Node 20 and 22.

Documentation:

  • Revise contributing guidelines, including updating issue and pull request templates, code of conduct, and stale bot configuration.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:49
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This PR updates the Auro Formkit project to use Node.js v22 and updates repository settings and documentation.

State diagram for CI/CD workflow changes

stateDiagram-v2
    [*] --> TestPhase

    state TestPhase {
        state "Run on Node v20.x" as N20
        state "Run on Node v22.x" as N22
        N20 --> N22: If successful
    }

    TestPhase --> ReleasePhase: All tests pass

    state ReleasePhase {
        state "Setup Node v22.x" as Setup
        Setup --> Build
        Build --> SemanticRelease
    }

    ReleasePhase --> [*]

    note right of ReleasePhase
        Now using Node v22.x
        for releases
    end note
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated the engines section in package.json to specify Node.js v20.x or v22.x
  • Regenerated package-lock.json
  • Updated the testPublish workflow to use Node.js v20.x and v22.x for testing and v22.x for release
  • Updated the settings.yml file to require tests on Node.js v20.x and v22.x
package.json
package-lock.json
.github/workflows/testPublish.yml
.github/settings.yml
Updated repository settings
  • Updated the homepage URL in settings.yml
  • Updated the list of topics in settings.yml
  • Updated the dismissal restrictions user in settings.yml
.github/settings.yml
Updated documentation
  • Minor updates to wording and formatting in CONTRIBUTING.md
  • Revised the pull request template to include a checklist and more detailed information
  • Minor updates to wording and formatting in CODE_OF_CONDUCT.md
  • Updated the bug report template to reference auro-formkit and its version badge
  • Updated the feature request template to reference auro-formkit
  • Updated the general support template to reference auro-formkit
.github/CONTRIBUTING.md
.github/PULL_REQUEST_TEMPLATE.md
.github/CODE_OF_CONDUCT.md
.github/ISSUE_TEMPLATE/bug_report.yml
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Added publishDemo workflow
  • Created a new workflow file named publishDemo.yml
  • Configured the workflow to trigger on pull requests to the main branch
  • Set up the workflow to call the publishDemo workflow from the auro-library repository
.github/workflows/publishDemo.yml
Updated stale.yml
  • Added newlines after each configuration option in stale.yml
.github/stale.yml
Updated CODEOWNERS
  • Updated the CODEOWNERS file, but the specific changes are not included in the diff
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

@rmenner rmenner changed the base branch from main to beta December 20, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
2 participants