Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dropdown's matchwidth and update select's max-height example #83

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

sun-mota
Copy link
Contributor

@sun-mota sun-mota commented Dec 3, 2024

Alaska Airlines Pull Request

Before Submitting this pull request:

  • Link all tickets in this repository related to this PR in the Development section
    note: all pull requests require at least one linked ticket
  • If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Fix the dropdown's 'matchwidth' functionality and update the select component's documentation and examples to reflect changes in CSS part naming for custom height settings.

Bug Fixes:

  • Fix the dropdown component's 'matchwidth' functionality to ensure the dropdown width matches the trigger element.

Enhancements:

  • Update the CSS part name from 'dropdownPopover' to 'dropdownSize' for setting custom height dimensions in the select component.

Documentation:

  • Update the select component documentation to reflect changes in CSS part naming and provide a clearer example of setting max-height.

@sun-mota sun-mota self-assigned this Dec 3, 2024
@sun-mota sun-mota changed the base branch from main to sunMota/dropdown-mobile-fullscreen/#55 December 3, 2024 21:19
@sun-mota sun-mota linked an issue Dec 3, 2024 that may be closed by this pull request
@AlaskaAirlines AlaskaAirlines deleted a comment from sourcery-ai bot Dec 3, 2024
@sun-mota sun-mota force-pushed the sunMota/update-select-sizing-doc/67 branch from 427cc7b to 52eefde Compare December 3, 2024 22:12
@sun-mota sun-mota linked an issue Dec 3, 2024 that may be closed by this pull request
1 task
@sun-mota sun-mota marked this pull request as ready for review December 4, 2024 21:11
@sun-mota sun-mota requested a review from a team as a code owner December 4, 2024 21:11
Copy link

sourcery-ai bot commented Dec 4, 2024

Reviewer's Guide by Sourcery

This PR fixes the dropdown's matchwidth functionality and updates the select component's styling. The main changes involve correcting CSS parts for proper sizing behavior and cleaning up demo-related code.

Class diagram for AuroDropdown changes

classDiagram
    class AuroDropdown {
        +exposeCssParts()
    }
    note for AuroDropdown "Updated exposeCssParts method to use 'size:dropdownSize' instead of 'popover:dropdownPopover'"
Loading

Class diagram for CSS changes in dropdown

classDiagram
    class DropdownStyles {
        +matchwidth
    }
    note for DropdownStyles "Added matchwidth functionality to set width to 100%"
Loading

File-Level Changes

Change Details Files
Fixed dropdown's matchwidth functionality by adding CSS styling for full-width behavior
  • Added CSS rule to make bibSizer element take 100% width when matchwidth is enabled
components/dropdown/src/styles/style.scss
Updated CSS part naming from dropdownPopover to dropdownSize for consistency
  • Changed CSS part name in component attribute export
  • Updated documentation and examples to use the new dropdownSize part name
components/dropdown/src/auro-dropdown.js
components/select/apiExamples/customBibHeight.html
components/select/docs/partials/index.md
components/select/demo/index.md
Cleaned up demo-related code and dependencies
  • Removed unused initExamples function
  • Updated marked.js usage to latest version
  • Removed duplicate design-tokens stylesheet link
  • Added auro-button script for demo purposes
components/select/demo/index.js
components/select/demo/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sun-mota - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

components/combobox/demo/api.min.js Outdated Show resolved Hide resolved
components/combobox/demo/index.min.js Outdated Show resolved Hide resolved
components/dropdown/demo/api.min.js Show resolved Hide resolved
components/dropdown/demo/index.min.js Show resolved Hide resolved
components/select/demo/api.min.js Outdated Show resolved Hide resolved
components/select/demo/index.min.js Outdated Show resolved Hide resolved
@sun-mota sun-mota force-pushed the sunMota/dropdown-mobile-fullscreen/#55 branch 2 times, most recently from 1f4e69f to faa6005 Compare December 4, 2024 23:54
Base automatically changed from sunMota/dropdown-mobile-fullscreen/#55 to main December 4, 2024 23:58
@sun-mota sun-mota force-pushed the sunMota/update-select-sizing-doc/67 branch from 52eefde to 8916056 Compare December 5, 2024 00:13
@rmenner rmenner self-requested a review December 5, 2024 18:57
@sun-mota sun-mota merged commit 51eea4a into main Dec 5, 2024
4 of 6 checks passed
@sun-mota sun-mota deleted the sunMota/update-select-sizing-doc/67 branch December 5, 2024 19:11
@rmenner
Copy link
Contributor

rmenner commented Dec 16, 2024

🎉 This PR is included in version 1.6.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SELECT: update custom width/height example on doc
3 participants