-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dropdown's matchwidth
and update select's max-height example
#83
Conversation
427cc7b
to
52eefde
Compare
Reviewer's Guide by SourceryThis PR fixes the dropdown's matchwidth functionality and updates the select component's styling. The main changes involve correcting CSS parts for proper sizing behavior and cleaning up demo-related code. Class diagram for AuroDropdown changesclassDiagram
class AuroDropdown {
+exposeCssParts()
}
note for AuroDropdown "Updated exposeCssParts method to use 'size:dropdownSize' instead of 'popover:dropdownPopover'"
Class diagram for CSS changes in dropdownclassDiagram
class DropdownStyles {
+matchwidth
}
note for DropdownStyles "Added matchwidth functionality to set width to 100%"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
1f4e69f
to
faa6005
Compare
52eefde
to
8916056
Compare
🎉 This PR is included in version 1.6.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Fix the dropdown's 'matchwidth' functionality and update the select component's documentation and examples to reflect changes in CSS part naming for custom height settings.
Bug Fixes:
Enhancements:
Documentation: