Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy es5 bundling resources #61

Closed
blackfalcon opened this issue Apr 9, 2023 · 2 comments · Fixed by #84
Closed

Remove legacy es5 bundling resources #61

blackfalcon opened this issue Apr 9, 2023 · 2 comments · Fixed by #84
Assignees
@fajar-apri-alaska
Labels
auro-header Status: Work In Progress Issue or Pull Request work is in Progress Type: Refactoring A code change that neither fixes a bug nor adds a feature
Milestone
Header: Node 18+ ...

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Apr 9, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This repo still contains resources related to the bundling of an es5 module, local demo Sass, and still supports legacy concepts like non-rem CSS post-processing.

Describe the solution you'd like

Remove all es5 resources required for bundling. This includes all script references and npm dependencies.

Remove these legacy services. Also, make sure that they are removed from all documentation including the README and API docs.

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released

Exit criteria

This issue will be complete once all legacy Sass and es5 building resources have been removed from the repo.

Related context

See linked commits for update references.
@blackfalcon blackfalcon added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Apr 9, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-badge Apr 9, 2023
@blackfalcon blackfalcon changed the title auro-badge: remove legacy es5 bundling resources Remove legacy es5 bundling resources Apr 9, 2023
@blackfalcon
Copy link
Member Author

/duplicate

@AuroDesignSystem AuroDesignSystem mentioned this issue Apr 10, 2023
Closed
@fajar-apri-alaska fajar-apri-alaska self-assigned this Apr 14, 2023
@fajar-apri-alaska fajar-apri-alaska linked a pull request Apr 14, 2023 that will close this issue
Node 18+ updates #84
Merged
3 tasks
fajar-apri-alaska added a commit that referenced this issue Apr 14, 2023
@fajar-apri-alaska
perf(es5): Remove legacy es5 bundling resources #61
420769c 
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    src/es5.js
@fajar-apri-alaska fajar-apri-alaska mentioned this issue Apr 14, 2023
Merged
3 tasks
@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label Apr 14, 2023
blackfalcon pushed a commit that referenced this issue Apr 18, 2023
@fajar-apri-alaska @blackfalcon
perf(es5): Remove legacy es5 bundling resources #61
dc1e95e 
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    src/es5.js
blackfalcon pushed a commit that referenced this issue Apr 19, 2023
@fajar-apri-alaska @blackfalcon
perf(es5): Remove legacy es5 bundling resources #61
57ca022 
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    src/es5.js
blackfalcon added a commit that referenced this issue Apr 19, 2023
@blackfalcon
perf(es5): remove postinstall instrucions #61
8a6deea 
Changes to be committed:
deleted:    scripts/postinstall.js
blackfalcon pushed a commit that referenced this issue Apr 19, 2023
@fajar-apri-alaska @blackfalcon
perf(es5): Remove legacy es5 bundling resources #61
a5fb346 
Changes to be committed:
	modified:   README.md
	deleted:    babel.config.js
	modified:   package-lock.json
	modified:   package.json
	deleted:    rollup.config.js
	new file:   rollup.config.mjs
	deleted:    src/es5.js
blackfalcon added a commit that referenced this issue Apr 19, 2023
@blackfalcon
perf(es5): remove postinstall instrucions #61
502cd66 
Changes to be committed:
deleted:    scripts/postinstall.js
blackfalcon pushed a commit that referenced this issue Apr 19, 2023
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
8224e8e 
# [2.0.0](v1.5.5...v2.0.0) (2023-04-19)

### Bug Fixes

* misimport pathto 'lit' package in auro-header.js ([0536f41](0536f41))

### Documentation

* **npm:** Update npm namespace [#70](#70) ([663ad0f](663ad0f))

### Features

* **typescript:** add typescript support [#68](#68) ([9c76756](9c76756))

### Performance Improvements

* **dev:** update run dev use single terminal [#65](#65) ([0e37cf9](0e37cf9))
* **es5:** Remove legacy es5 bundling resources [#61](#61) ([a5fb346](a5fb346))
* **es5:** remove postinstall instrucions [#61](#61) ([502cd66](502cd66))
* **husky:** Pre-commit and husky update [#63](#63) ([2568b60](2568b60))
* **lit:** Update to Lit2.0 [#66](#66) ([e9fa9ef](e9fa9ef))
* **node18:** Update to support node 18++ [#64](#64) ([9419a4d](9419a4d))
* **postCss:** update to postCss.js & remove unused resource ([5e401a9](5e401a9))
* **sass:** Update Sass to use dart-sass dependency [#62](#62) ([1a26b20](1a26b20))

### BREAKING CHANGES

* **npm:** This update will redefine the npm namespace
for the auro-header element.

Changes to be committed:
modified:   README.md
modified:   package.json
@blackfalcon
Copy link
Member Author

/duplicate

This was referenced Apr 21, 2023
Closed
Closed
This was referenced May 4, 2023
Closed
Closed
Closed
Closed
This was referenced May 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

Labels
auro-header Status: Work In Progress Issue or Pull Request work is in Progress Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
Header: Node 18+ support
Development

Successfully merging a pull request may close this issue.

Node 18+ updates AlaskaAirlines/auro-header
2 participants
@blackfalcon @fajar-apri-alaska