Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove components dir from sweep command #357

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

chrisfalaska
Copy link
Contributor

@chrisfalaska chrisfalaska commented Nov 4, 2024

Alaska Airlines Pull Request

The sweep command was updated in 341 to search for the /components/ folder, which is currently exclusive to the new auro-form component under development as of AlaskaAirlines/auro-formkit#1.

Resolves: 356

Summary:

  • Removed the /components/ folder from the sweep command
  • Returned the rm command to remove the dist and demo/css folders

Type of change:

Please delete options that are not relevant.

  • Revision of an existing capability

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Bug Fixes:

  • Remove the 'components' directory from the 'sweep' command in the package.json to prevent unintended file deletions.

Summary by Sourcery

Bug Fixes:

  • Remove the 'components' directory from the 'sweep' command in the package.json to prevent unintended file deletions.

@chrisfalaska chrisfalaska self-assigned this Nov 4, 2024
@chrisfalaska chrisfalaska linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link

sourcery-ai bot commented Nov 4, 2024

Reviewer's Guide by Sourcery

The PR modifies the sweep command in package.json to remove references to the /components/ directory and reintroduces the rm command to explicitly remove the dist and demo/css folders. This change prevents unintended file deletions from the components directory while maintaining cleanup functionality for other directories.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the sweep command in package scripts to remove components directory scanning
  • Removed /components/ directory from the find command path
  • Added explicit rm -rf command to remove dist and demo/css folders
  • Maintained find command for cleaning up CSS and CSS.js files in demo, dist, and src directories
package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chrisfalaska chrisfalaska marked this pull request as ready for review November 4, 2024 19:39
@chrisfalaska chrisfalaska requested a review from a team as a code owner November 4, 2024 19:39
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisfalaska - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There appears to be a typo in the sweep command: ./-type should be -type. This will cause the find command to fail.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

package.json Outdated Show resolved Hide resolved
@chrisfalaska
Copy link
Contributor Author

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chrisfalaska - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chrisfalaska chrisfalaska merged commit 5eb7b36 into main Nov 6, 2024
6 checks passed
@chrisfalaska chrisfalaska deleted the cfriedberg/356 branch November 6, 2024 19:55
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove components folder from Sweep task
3 participants