Drake/feature/simulated uhf #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheadrick1618
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Code looks great!
Also you will have to resolve these pylint formatting errors before your branch can be merged:
Run pylint $(git ls-files '*.py')
************* Module UHF.generic_client
UHF/generic_client.py:53:0: W0311: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
UHF/generic_client.py:54:0: W0311: Bad indentation. Found 16 spaces, expected 12 (bad-indentation)
UHF/generic_client.py:55:0: W0311: Bad indentation. Found 20 spaces, expected 16 (bad-indentation)
UHF/generic_client.py:16:0: C0116: Missing function or method docstring (missing-function-docstring)
UHF/generic_client.py:23:15: W0[7](https://github.com/AlbertaSat/ex3_simulated_subsystems/actions/runs/10001102874/job/27644142253?pr=64#step:5:8)18: Catching too general exception Exception (broad-exception-caught)
UHF/generic_client.py:30:0: C0116: Missing function or method docstring (missing-function-docstring)
UHF/generic_client.py:5[8](https://github.com/AlbertaSat/ex3_simulated_subsystems/actions/runs/10001102874/job/27644142253?pr=64#step:5:9):15: W0718: Catching too general exception Exception (broad-exception-caught)
UHF/generic_client.py:30:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
************* Module UHF.simulated_uhf
UHF/simulated_uhf.py:5[9](https://github.com/AlbertaSat/ex3_simulated_subsystems/actions/runs/10001102874/job/27644142253?pr=64#step:5:10):21: C0303: Trailing whitespace (trailing-whitespace)
UHF/simulated_uhf.py:105:26: C0303: Trailing whitespace (trailing-whitespace)
UHF/simulated_uhf.py:66:19: W0718: Catching too general exception Exception (broad-exception-caught)
UHF/simulated_uhf.py:[10](https://github.com/AlbertaSat/ex3_simulated_subsystems/actions/runs/10001102874/job/27644142253?pr=64#step:5:11)5:11: W0718: Catching too general exception Exception (broad-exception-caught)
UHF/simulated_uhf.py:89:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
UHF/simulated_uhf.py:138:23: W0718: Catching too general exception Exception (broad-exception-caught)
UHF/simulated_uhf.py:172:15: W0718: Catching too general exception Exception (broad-exception-caught)
UHF/simulated_uhf.py:177:0: C0[11](https://github.com/AlbertaSat/ex3_simulated_subsystems/actions/runs/10001102874/job/27644142253?pr=64#step:5:12)6: Missing function or method docstring (missing-function-docstring)
-----------------------------------
Your code has been rated at 9.84/10
dheadrick1618
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created python programs for simulating uhf transceiver. One of these is a test program (generic_client.py).