fix(HTTP Cache): Use cache_key_with_version for etag #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
cache-key-with-version
branch
from
ecfcd22 to
bbe4fbc
Compare
tvdeyen
force-pushed
the
cache-key-with-version
branch
3 times, most recently
from
c86c7e5 to
cb91975
Compare
The cache_key is just the page id. We need to include the cache_version (the page published_at date).
tvdeyen
force-pushed
the
cache-key-with-version
branch
from
cb91975 to
0b28e43
Compare
sascha-karnatz
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cache_keyis just the page id. We need to include thecache_version(the pagepublished_atdate).