Remove element_dom_id helper #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
remove-element-dom-id
branch
3 times, most recently
from
f4d0dc4 to
4ea29d5
Compare
mamhoff
approved these changes
Sep 4, 2022
6.1 |
tvdeyen
force-pushed
the
remove-element-dom-id
branch
from
4ea29d5 to
9af22cd
Compare
We cannot use the id, because that will change if publish the page. The position will be the same across versions and combined with the name it is unique on each page. Fixes AlchemyCMS#2354
Use `element.dom_id` instead.
Please implement your own unique DOM ID for your elements and pass it as anchor to your URLs.
tvdeyen
force-pushed
the
remove-element-dom-id
branch
from
9af22cd to
2b8680c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Builds on top of #2368
Removes two previously deprecated helpers
Checklist