Deprecate Alchemy.enable_searchable for Alchemy.config.show_page_searchable_checkbox
#3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to deprecate these methods.
We only want to forego validation if the value passed into an option is `nil`, not when it's false.
mamhoff
force-pushed
the
deprecate-enable-searchable
branch
from
09ea945 to
c442d40
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3188 +/- ##
=======================================
Coverage 96.69% 96.70%
=======================================
Files 256 256
Lines 6606 6613 +7
=======================================
+ Hits 6388 6395 +7
Misses 218 218 ☔ View full report in Codecov by Sentry. |
mamhoff
force-pushed
the
deprecate-enable-searchable
branch
from
c442d40 to
f9a1a77
Compare
tvdeyen
approved these changes
Feb 10, 2025
lib/alchemy/configurations/main.rb
Outdated
| # | ||
| # # config/initializers/alchemy.rb | ||
| # Alchemy.config.page_searchable_checkbox = true | ||
| option :page_searchable_checkbox, :boolean, default: false |
There was a problem hiding this comment.
What about show_page_searchable_checkbox ?
Instead, use the `Alchemy.config.page_searchable_checkbox` Boolean.
mamhoff
force-pushed
the
deprecate-enable-searchable
branch
from
f9a1a77 to
4f69f7c
Compare
|
@mamhoff can we update the commit message and PR description for the new config name as well? |
mamhoff
changed the title
Alchemy.enable_searchable for Alchemy.config.page_searchable_checkboxAlchemy.enable_searchable for Alchemy.config.show_page_searchable_checkbox
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This moves one configuration option from the
Alchemymodule to theAlchemy.configobject. It renames the option fromAlchemy.enable_searchablewhich doesn't provide a lot of clarity toAlchemy.show_page_searchable_checkboxwhich is somewhat clearer I think.There's also a refactoring in this PR that should prepare the work on the other configuration options in
lib/alchemy.rb.Notable changes (remove if none)
Alchemy.enable_searchable.Alchemy.config.show_page_searchable_checkbox.Checklist