Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logger with interceptors #87

Closed
wants to merge 5 commits into from
Closed

Conversation

Aldas1
Copy link
Owner

@Aldas1 Aldas1 commented Nov 6, 2023

No description provided.

Copy link
Collaborator

@piatrashkakanstantinass piatrashkakanstantinass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore log

How does it work? I tried shutting down db server and my project would raise exceptions, but file is empty.

@piatrashkakanstantinass
Copy link
Collaborator

Could you perhaps make use of custom exceptions? (#91)

@piatrashkakanstantinass
Copy link
Collaborator

remove catch Exception in ExplanationService

@piatrashkakanstantinass
Copy link
Collaborator

🔥Merge conflicts

@piatrashkakanstantinass
Copy link
Collaborator

Custom exception cannot be named as CustomException, it must have some meaning. You need to meaningfully deal with it (and store some useful data in it).

Copy link
Collaborator

@danieliuspdb danieliuspdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe throw the username of user that already exists

@piatrashkakanstantinass
Copy link
Collaborator

Maybe throw the username of user that already exists

No need for that, it is already obvious which user does not exist

@piatrashkakanstantinass
Copy link
Collaborator

doesn't log exceptions

@piatrashkakanstantinass piatrashkakanstantinass deleted the feat/exception_logging branch November 20, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants