Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create document object in interaction handler scope #31

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

AlecM33
Copy link
Owner

@AlecM33 AlecM33 commented Mar 23, 2024

We were problematically using a global document variable for the wordcloud command, which had the potential to cause side effects with asynchronous processing. Now we're being a bit less dumb.

@AlecM33 AlecM33 merged commit 7daa471 into main Mar 23, 2024
@AlecM33 AlecM33 deleted the no-global-document branch March 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant