[Cleanup] Timestamp GC #3187
Merged
[Cleanup] Timestamp GC #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardwu
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Bullshark, timestamps on certificates are used during garbage collection to ensure that slow validators are still able to contribute to the DAG, rather than having their certificates dropped due to a slow network. To accomplish this, Bullshark garbage collects entire rounds rather than individual certificates. In particular, during GC, Bullshark will check if the difference between the median timestamp of a round and the timestamp of the leader being committed exceeds a specified upper bound. If it does, the entire round and those preceding it are garbage collected. Bullshark uses this algorithm to reach a balance between fairness and bounded memory.