Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate crate failure in favor of thiserror #85

Merged
merged 2 commits into from
May 10, 2020

Conversation

collinc97
Copy link
Contributor

fixes #69

@collinc97 collinc97 requested a review from howardwu May 9, 2020 23:59
@howardwu
Copy link
Contributor

SGTM pending CI

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #85 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   88.94%   88.96%   +0.01%     
==========================================
  Files         231      229       -2     
  Lines       14161    14396     +235     
==========================================
+ Hits        12596    12807     +211     
- Misses       1565     1589      +24     
Impacted Files Coverage Δ
errors/src/algorithms/commitment.rs 0.00% <0.00%> (ø)
errors/src/algorithms/crh.rs 0.00% <0.00%> (ø)
errors/src/algorithms/merkle.rs 0.00% <0.00%> (ø)
errors/src/algorithms/prf.rs 0.00% <0.00%> (ø)
errors/src/algorithms/signature.rs 0.00% <0.00%> (ø)
errors/src/algorithms/snark.rs 0.00% <0.00%> (ø)
errors/src/consensus/consensus.rs 0.00% <0.00%> (ø)
errors/src/curves/constraint_field.rs 0.00% <0.00%> (ø)
errors/src/dpc/binding_signature.rs 0.00% <0.00%> (ø)
errors/src/dpc/dpc.rs 0.00% <0.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f1094...967a7a5. Read the comment docs.

@collinc97 collinc97 merged commit b4556d5 into master May 10, 2020
@collinc97 collinc97 deleted the feature/deprecate-failure branch May 10, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure is now deprecated
2 participants