Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document-index): use chunk overlap when creating a new index #1050

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(document-index): use chunk overlap when creating a new index #1050

merged 1 commit into from
Sep 30, 2024

Conversation

TilTheunissenAA
Copy link
Contributor

@TilTheunissenAA TilTheunissenAA commented Sep 26, 2024 •
edited by NiklasKoehneckeAA
Loading

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@TilTheunissenAA TilTheunissenAA merged commit e9780f9 into main Sep 30, 2024
4 checks passed
@TilTheunissenAA TilTheunissenAA deleted the fix-document-index-chunk-overlap branch September 30, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasKoehneckeAA NiklasKoehneckeAA NiklasKoehneckeAA approved these changes

@Michael-JB Michael-JB Michael-JB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TilTheunissenAA @Michael-JB @NiklasKoehneckeAA