Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document-index): add hybrid_index to index configuration #1052

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

TilTheunissenAA
Copy link
Contributor

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case


assert "Poison in food is bad" in search_results[0].section
assert "All people like pasta" in search_results[1].section
assert "Chairs are not food" in search_results[2].section
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Challenge accepted

@Michael-JB Michael-JB merged commit c537072 into main Sep 27, 2024
4 checks passed
@Michael-JB Michael-JB deleted the di-204-hybrid-search branch September 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants